Add a small arrow for dropdowns #8950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitvakatu
added
CI: No changelog needed
vitvakatu
requested review from
Frizi,
farmaazon,
MichaelMauderer and
kazcw
as code owners
farmaazon
reviewed
Feb 5, 2024
Comment on lines
135
to
137
| const childWidgetRef = ref<HTMLElement>() | ||
| const childSize = useResizeObserver(childWidgetRef) | ||
| const arrowPos = computed(() => (childSize.value != null ? childSize.value.x / 2 : 0)) |
There was a problem hiding this comment.
I don't quite like that we position this arrow in a programmatic way. Perhaps we could do some CSS trick here @Frizi ?
There was a problem hiding this comment.
We could. The arrow could be centered by CSS in many ways. Here probably the esasiest would be margin: 0 auto;, or left: 50%; margin-left: -50%;
5 tasks
farmaazon
approved these changes
Feb 7, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 12, 2024
Closes #8932 Now we use a bit more robust mechanism for passing dynamic configuration down the widget tree inside dropdowns, no longer relying on the `label`s used for dropdown items. Curiously, we still need to use a hotfix implemented earlier, as we won’t have info about the currently selected item otherwise. Highlight for the currently selected item is not crucial as proper dynamic config, so we can leave with the current solution in the meantime. No visual changes to the IDE, apart from fixed highlight for currently selected item. # Important Notes Target branch: #8950, for easier testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
A temporary solution for #8949. Not pretty, but it solves the issue for now.
arrows.for.dropdowns.mp4
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.