Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further optimizations to test resources #8936

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Conversation

hubertp
Copy link
Collaborator

@hubertp hubertp commented Feb 1, 2024

Pull Request Description

TestRuntime should be deprecated as it creates a number of threads and doesn't allow to easily modify ZIO's runtime.
But the biggest drop stems from fixing leaking FileSystemService that weren't being closed for every TextOperationsTest test.
The change is a follow up on #8892 but this time focused on ZIO usage.

Hopefully fixes #8806 for good.

Important Notes

Running language-server/test.
Before:
Screenshot from 2024-02-02 09-48-32

After:
Screenshot from 2024-02-02 09-46-02

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.

TestRuntime should be deprecated as it creates a number of threads and
doesn't allow to easily modify ZIO's runtime.
The change helps to futher drop allocated threads.
@hubertp hubertp added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 2, 2024
@hubertp hubertp marked this pull request as ready for review February 2, 2024 08:52
Copy link
Member

@Akirathan Akirathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The number of alive threads dropped almost twice. Nice. Have you also, by any chance, checked the total time it takes to run language-server/test? I don't expect any drastic slowdown, just out of curiosity.

@hubertp
Copy link
Collaborator Author

hubertp commented Feb 2, 2024

Have you also, by any chance, checked the total time it takes to run language-server/test? I don't expect any drastic slowdown, just out of curiosity.

Within the same ballpark. I was experimenting with the number of threads in threadpools.

@hubertp hubertp added the CI: Ready to merge This PR is eligible for automatic merge label Feb 2, 2024
@mergify mergify bot merged commit 34e1bac into develop Feb 2, 2024
27 of 28 checks passed
@mergify mergify bot deleted the wip/hubert/8806-zio branch February 2, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language Server LibrariesTest & co. tests fail due to timeouts in CI
3 participants