-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canonicalize the temporary directory files #8879
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
Do not require a changelog entry for this PR.
label
Jan 27, 2024
JaroslavTulach
requested review from
4e6,
hubertp and
Akirathan
as code owners
January 27, 2024 06:04
Sample failure to be fixed:
|
Mac CI run is green. Marking ready to merge and waiting for a code owner blessing. |
JaroslavTulach
added
the
CI: Ready to merge
This PR is eligible for automatic merge
label
Jan 27, 2024
GregoryTravis
approved these changes
Jan 27, 2024
hubertp
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: No changelog needed
Do not require a changelog entry for this PR.
CI: Ready to merge
This PR is eligible for automatic merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Due to some Mac OS X symlinks trickery we need to canonicalize files created by
@Rule TemporaryFolder
to compare them for equality.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,
style guides.