Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump more details when two objects at the same locations are read #8802

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Jan 18, 2024

Pull Request Description

Closes #8792 by dumping more information about the incident and in the (likely) case both objects are equal, just logging the exception without terminating the execution.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
    style guides.
  • All code has been tested:
    • Existing unit tests continue to pass

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 18, 2024
@JaroslavTulach JaroslavTulach self-assigned this Jan 18, 2024
final class PerUtils {
private PerUtils() {}

static final Logger LOG = Logger.getLogger(Persistance.class.getPackageName());
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hubert, there is #8644 - you can resolve it by providing a guidance during this review.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hubertp, I haven't heard any guidance on using logger properly to avoid pitfalls described by

Anyway, this PR doesn't make the current state worse. Integrating and hoping you'll be able to improve the logging here when processing #8644

@JaroslavTulach JaroslavTulach merged commit 5d877ab into develop Jan 19, 2024
26 of 28 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/MoreDetails_8792 branch January 19, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to read BindingsMap cache
2 participants