Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: don't build native runner on gui workflow #8726

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

mwu-tow
Copy link
Contributor

@mwu-tow mwu-tow commented Jan 10, 2024

Pull Request Description

Native runner was previously enabled for all backend builds involving engine build. Now this is limited only to backend CI job, so it won't be built as part of GUI CI.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@mwu-tow mwu-tow added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 10, 2024
@mwu-tow mwu-tow self-assigned this Jan 10, 2024
@mwu-tow mwu-tow marked this pull request as ready for review January 11, 2024 10:56
@mwu-tow mwu-tow merged commit ed410a8 into develop Jan 12, 2024
25 of 27 checks passed
@mwu-tow mwu-tow deleted the wip/mwu/dont-build-native-runner-without-need branch January 12, 2024 03:59
@mwu-tow mwu-tow mentioned this pull request Jan 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants