-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Table_Tests to the builder API #8622
Merged
Merged
Changes from all commits
Commits
Show all changes
98 commits
Select commit
Hold shift + click to select a range
0ca0e48
Skeleton of Test_New builder API
Akirathan 1d6cdba
Add Test_New standard library.
Akirathan f31fd10
Copy some stuff from Test to Test_New
Akirathan 0e00586
Test_New accepts filters
Akirathan b2da2ce
Add Proposition_1.enso prototype
Akirathan c72967f
Revert "Test_New accepts filters"
Akirathan 987efb6
Fix imports in Proposition (2) and add some prints
Akirathan 38d85ff
Rename Test_New.enso to Test.enso
Akirathan 268234f
Refactor Test_New/Test to multiple source files
Akirathan b55b595
Implement Suite.merge, add prototype of Test/Main_New.enso
Akirathan 4255c94
Initial version of SQLite_Spec migration
Akirathan 9e0a498
Move Suite.build to Test.build
Akirathan c65efc3
Split Test_Result into Spec_Result
Akirathan 7a749ed
Move test running logic into Helpers module
Akirathan 40a2873
Add Test_Reporter from Test lib
Akirathan 2ef29f2
Group and Spec can be pending
Akirathan 22bc28f
Add Suite.run_with_filter
Akirathan 4e5fced
Merge branch 'develop' into wip/akirathan/7566-stdlib-test-builder-api
Akirathan 5b961c4
Introduce group_with_setup and specify_with_args methods to the API.
Akirathan 25fbe49
Remove group_with_setup and specify_with_args and replace it with tea…
Akirathan 4795e18
Remove Proposition_1.enso
Akirathan 29baa8e
Default_Ordering_Spec_New gets connection_provider instead of connect…
Akirathan aae5c6c
teardown is not called if the group is empty
Akirathan 75842f0
Copy Problems from Test into Test_New
Akirathan 61a8acc
Removed the bugged assertion
Akirathan 99ce849
Run only the failing test
Akirathan 172eaf9
Add Common_Spec_New
Akirathan 8c0fe40
Merge branch 'develop' into wip/akirathan/7566-stdlib-test-builder-api
Akirathan a9cf3ee
Integrate simpler lazy field initialization.
Akirathan 5b51c65
Replace Default_Ordering_Spec
Akirathan eeaa5d2
Replace Common_Spec with the builder API
Akirathan b25ea2c
Group can be pending
Akirathan 80375e8
Refactor bunch of Table_Test files to the new builder API
Akirathan d152c22
Remove SQLite_Spec_New
Akirathan ce8df7b
Fix JUnit xml output
Akirathan 02e22cb
Fix Upload_Spec
Akirathan 9f0da9d
Copy more sources from Test into Test_New
Akirathan a0a0a3a
Fix some typos causing runtime errors
Akirathan 8789d7b
Test_Setup.Config.table_builder accepts connection parameter.
Akirathan 43b22a0
Implement Util.run_default_backend
Akirathan 602d382
Fix Date_Time_Spec
Akirathan 1946e30
Add main method to some tests.
Akirathan 9ccbdc0
Fix Missing_Values_Spec
Akirathan 3ae3a7f
Fix Order_By_Spec
Akirathan 4a6afef
Fix Select_Columns_Spec
Akirathan b152643
Fix Take_Drop_Spec
Akirathan a07754d
Add some more main methods to tests
Akirathan bc4ba75
Use the same connection for table_builder in Integration_Tests
Akirathan af23b65
Fix setup in Core_Spec
Akirathan 10d1f3e
Fix setup in Upload_Spec
Akirathan 3076078
Fix setup in Union_Spec
Akirathan 25662a4
Fix setup in Lookup_Spec
Akirathan ddb97e2
Fix some typos
Akirathan 45be065
Fix typos in SQLite_Spec
Akirathan 9574b3a
Remove Bool_Spec_New from Base_Test
Akirathan 6b42315
Refactor Table_Tests/src/Helpers to Test_New
Akirathan a16aa29
Refactor Table_Tests/src/In_Memory to Test_New
Akirathan 12b6ae4
Remove unused Table_Tests/src/In_Memory/Common_Spec
Akirathan 348af3f
WIP: Fix "Keys are not Text" test
Akirathan 5e3114e
Refactor Table_Tests/src/IO to Test_New
Akirathan 2f28af4
Refactor Table_Tests/src/Formatting to Test_New
Akirathan 110abff
Refactor Codegen_Spec to the new API
Akirathan ca65fe4
Add some teardowns.
Akirathan 666b1f7
Refactor Postgres tests to Test_New
Akirathan 9955e63
Add teardowns to Column_Operations_Spec
Akirathan d85b138
Enable some temporary disabled tests
Akirathan f4906ba
Fix teardowns in Aggregate_Spec
Akirathan bd676f9
Add more teardowns.
Akirathan 32ac4e8
Add docs how to run Postgres in Docker for testing
Akirathan 9864a5a
Fix typo in Integration_Tests
Akirathan 602fb47
Refactor Redshift tests to Test_New
Akirathan 14fa1bc
Fix typos
Akirathan 0e85566
Merge branch 'develop' into wip/akirathan/7566-stdlib-test-builder-api
Akirathan 0b9d063
Remove empty file
Akirathan 37ed88e
Remove Phases from Test_New
Akirathan 5ea134a
Add docs to Test_New
Akirathan 7bc400b
Add docs to Test_New
Akirathan 587b287
Remove Suite.run_all method
Akirathan cffdad3
Filter can be either Regex, Text, or Nothing
Akirathan 0a7a527
Print test stats at the end of the run
Akirathan ef3a408
Refactor Table_Tests/src/Main.enso to Test_New
Akirathan 357b084
Implement `add_specs` method in all Main.enso files.
Akirathan 6b50c3d
Remove temporary printing
Akirathan 54c216f
Set ENSO_TEST_ANSI_COLORS to true when running enso tests
Akirathan 84c2f61
Add In_Memory/Common_Spec
Akirathan e69f50b
Fix teardowns in Common_Table_Operations/Join
Akirathan 06be31e
Merge Test/Extensions into Test_New/Extensions
Akirathan bb18f42
Remove temporary printing
Akirathan 0935ba7
Merge branch 'develop' into wip/akirathan/7566-stdlib-test-builder-api
Akirathan 390e7e3
Refactor Nothing_Spec to Test_New after merge
Akirathan b1e45d3
Fix cargo lint
Akirathan d8af7ea
Refactor Base_Tests/Numbers_Spec to Test_New
Akirathan 774ccbf
In_Memory/Main includes specs from In_Memory/Common_Spec
Akirathan 9b2b4e7
Run both old and new tests in Base_Tests/Main.enso
Akirathan 305f024
Add should_exit parameter to Suite.run_with_filter
Akirathan 6496a86
Fix some typos
Akirathan b650a6b
Merge branch 'develop' into wip/akirathan/7566-stdlib-test-builder-api
mergify[bot] 31a340a
fmt
Akirathan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
name: Test_New | ||
namespace: Standard | ||
version: 0.0.0-dev | ||
license: APLv2 | ||
authors: | ||
- name: Enso Team | ||
email: [email protected] | ||
maintainers: | ||
- name: Enso Team | ||
email: [email protected] |
11 changes: 11 additions & 0 deletions
11
distribution/lib/Standard/Test_New/0.0.0-dev/src/Clue.enso
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
private | ||
|
||
## PRIVATE | ||
type Clue | ||
## PRIVATE | ||
|
||
Represents a clue as to why a test failed | ||
|
||
Arguments: | ||
- add_clue: either Nothing or a function which modifies a failure message | ||
Value add_clue |
15 changes: 15 additions & 0 deletions
15
distribution/lib/Standard/Test_New/0.0.0-dev/src/Execution_Context_Helpers.enso
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
from Standard.Base import all | ||
import Standard.Base.Runtime.Context | ||
|
||
import project.Test.Test | ||
|
||
## PRIVATE | ||
Runs the action twice, once with the Output context enabled and once with it | ||
disabled, to check that the behaviour is the same regardless of context. | ||
run_with_and_without_output ~action = | ||
Context.Output.with_enabled <| | ||
Test.with_clue "(normal mode - Output context enabled) " <| | ||
action | ||
Context.Output.with_disabled <| | ||
Test.with_clue "(dry run - Output context disabled) " <| | ||
action |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just makes the output of the tests more colorful. Like so:
(Inspired by the output from ScalaTest framework)