Handle Nothing values in Filter_Condition.to_predicate
#8600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
added
the
CI: No changelog needed
radeusgd
commented
Dec 20, 2023
Comment on lines
+202
to
+212
| Equal_Ignore_Case value locale -> | ||
| handle_nothing <| txt-> (txt : Text).equals_ignore_case value locale | ||
| Starts_With prefix case_sensitivity -> | ||
| handle_nothing <| txt-> (txt : Text).starts_with prefix case_sensitivity | ||
| Ends_With suffix case_sensitivity -> | ||
| handle_nothing <| txt-> (txt : Text).ends_with suffix case_sensitivity | ||
| Contains substring case_sensitivity -> | ||
| handle_nothing <| txt-> (txt : Text).contains substring case_sensitivity | ||
| Not_Contains substring case_sensitivity -> | ||
| handle_nothing <| txt-> (txt : Text).contains substring case_sensitivity . not |
There was a problem hiding this comment.
I added the txt:Text checks, because I think that Expected txt to be Text, but got [...]. will be more readable than e.g. Method .equals_ignore_case of type [...] could not be found..
radeusgd
commented
Dec 20, 2023
Comment on lines
+318
to
+325
| txtvec = alter ["abab", "baaa", Nothing, "cccc", "BAAA"] | ||
| txtvec.filter (Filter_Condition.Equal_Ignore_Case "baaA") . should_equal ["baaa", "BAAA"] | ||
| txtvec.filter (Filter_Condition.Contains "a") . should_equal ["abab", "baaa"] | ||
| txtvec.filter (Filter_Condition.Starts_With "a") . should_equal ["abab"] | ||
| txtvec.filter (Filter_Condition.Ends_With "a") . should_equal ["baaa"] | ||
| txtvec.filter (Filter_Condition.Like "b%a") . should_equal ["baaa"] | ||
| # Nothing is not included in the negation either | ||
| txtvec.filter (Filter_Condition.Not_Like "b%a") . should_equal ["abab", "cccc", "BAAA"] |
There was a problem hiding this comment.
Note, here we 'break' the property that
forall v p,
(v.filter (Filter_Condition.Like p)) + (v.filter (Filter_Condition.Not_Like p)) . length == v.length
because the Nothing values do not get into either category.
I think that is OK, because Like and Not_Like are both Text filters that return _Text_s that satisfy a condition, Nothing is neither like nor not-like a pattern.
Do you think that is OK?
I'm also fine with including Nothing in the Not_Like case if that is preferred.
radeusgd
force-pushed
the
wip/radeusgd/8549-vector-filter-allow-nulls
branch
from
75d638e to
31136bd
Compare
GregoryTravis
approved these changes
Dec 20, 2023
radeusgd
force-pushed
the
wip/radeusgd/8549-vector-filter-allow-nulls
branch
from
31136bd to
88a5da6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Vector.filterbyFilter_Conditiondoes not work well withNothing#8549Type_Erroris thrown instead of aNo_Such_Methoderror on type mismatches.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.