Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime test build depends on fat jar classes #8588

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Dec 19, 2023

Pull Request Description

Followup to #8467

Fixes the issue when runtime/test command fails to compile without fat jar classes:

sbt:enso> runtime/test
[warn] JPMSPlugin: Directory /home/dbushev/projects/luna/enso/engine/runtime-fat-jar/target/scala-2.13/classes does not exist.
[warn] JPMSPlugin: Directory /home/dbushev/projects/luna/enso/engine/runtime-fat-jar/target/scala-2.13/classes does not exist.
[info] compiling 106 Scala sources and 60 Java sources to /home/dbushev/projects/luna/enso/engine/runtime/target/scala-2.13/test-classes ...
[warn] Unexpected javac output: error: module not found: org.enso.runtime
[warn] 1 error.
[warn] frgaal exited with exit code 1
[error] (runtime / Test / compileIncremental) javac returned non-zero exit code

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label Dec 19, 2023
@4e6 4e6 self-assigned this Dec 19, 2023
@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label Dec 19, 2023
@mergify mergify bot merged commit 6983474 into develop Dec 19, 2023
31 of 32 checks passed
@mergify mergify bot deleted the wip/db/fix-runtime-test branch December 19, 2023 13:27
Comment on lines +1660 to +1663
),
Test / compile := (Test / compile)
.dependsOn(`runtime-fat-jar` / Compile / compileModuleInfo)
.value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably could have been achieved by adding

.dependsOn(`runtime-fat-jar` % "test->compile")

to the dependencies of runtime in

enso/build.sbt

Line 1734 in 21d164e

.dependsOn(`runtime-test-instruments` % "test->compile")
. But this should be even better. Thanks for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants