Remove the Apache dependency from std-base
#8571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
added
the
CI: No changelog needed
radeusgd
changed the base branch from
develop
to
wip/radeusgd/8354-cloud-tests-2
radeusgd
force-pushed
the
wip/radeusgd/url-encode
branch
3 times, most recently
from
8d3625d to
734b5e2
Compare
radeusgd
requested review from
jdunkerley,
GregoryTravis,
4e6,
JaroslavTulach,
hubertp and
Akirathan
as code owners
GregoryTravis
approved these changes
Dec 19, 2023
JaroslavTulach
approved these changes
Dec 19, 2023
| @@ -6,26 +6,6 @@ The license information can be found along with the copyright notices. | |||
| Copyright notices related to this dependency can be found in the directory `com.ibm.icu.icu4j-73.1`. | |||
|
|
|||
|
|
|||
| 'commons-codec', licensed under the The Apache Software License, Version 2.0, is distributed with the Base. | |||
There was a problem hiding this comment.
Lightweight dependencies are better!
hubertp
approved these changes
Dec 19, 2023
radeusgd
force-pushed
the
wip/radeusgd/url-encode
branch
from
734b5e2 to
eef7793
Compare
radeusgd
added
the
CI: Clean build required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
URLEncodebuiltin util. I will see if this does not complicate other followup improvements, but most likely all should work so we should be able to get rid of the unnecessary bloat.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.