-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter for test/Benchmarks #8391
Conversation
enso$ enso --run test/Benchmarks/ Computing_Proxy
Found 1 benchmark suites, containing 2 specs in total.
The minimal estimated run time based on configurations is 24s.
Found 2 cases to execute (ETA 24s)
Benchmark 'Vector_Array_Proxy.Sum_Computing_Proxy' finished in 12207.738 ms
Benchmark 'Vector_Array_Proxy.Sum_Vector_relying_on_Computing_Proxy' finished in 12028.108 ms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing documentation in docs/infrastructure/benchmarks.md
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice quality of life improvement. Please add docs either to benchmarks.md
or attach a doc comment to the main
method. It is not entirely clear how the filter
parameter should work.
Pull Request Description
With herein proposed change one can pass an optional filter to
enso --run test/Benchmarks
to execute only groups and specs that contain given string in its name.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
style guides.