Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local scope filtering #8109

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Local scope filtering #8109

merged 4 commits into from
Oct 23, 2023

Conversation

farmaazon
Copy link
Contributor

Pull Request Description

The "Local scope filtering" button works now.

image

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • [ ] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@farmaazon farmaazon added CI: No changelog needed Do not require a changelog entry for this PR. -gui labels Oct 19, 2023
@farmaazon farmaazon self-assigned this Oct 19, 2023
@farmaazon farmaazon requested a review from Frizi as a code owner October 19, 2023 13:59
...filterFlags.value,
})
const currentModule = projectStore.modulePath
console.log(currentModule)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log

makeModuleMethod('Standard.Base.Data.read'),
makeLocal('local.Project.Another_Module', 'local_in_another_module'),
makeFunction('local.Project.Another_Module', 'function_in_another_module'),
])('$name entry i not in Local Scope View', (entry) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in test name

@farmaazon farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label Oct 20, 2023
@mwu-tow mwu-tow merged commit 675fff0 into develop Oct 23, 2023
30 of 34 checks passed
@mwu-tow mwu-tow deleted the wip/farmaazon/local-scope-filtering branch October 23, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants