Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gui2] Language Server binary protocol, and loading of visualization data #7873

Merged
merged 155 commits into from
Oct 7, 2023
Merged

[gui2] Language Server binary protocol, and loading of visualization data #7873

merged 155 commits into from
Oct 7, 2023

Conversation

somebody1234
Copy link
Contributor

Pull Request Description

  • Depends on Vue visualizations #7773.

  • Implements binary WebSocket protocol (data protocol)

  • Performs some editor initialization (the bare minimum so that visualizations work)

  • Adds event handlers to receive visualization data updates

Important Notes

None

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

Frizi and others added 30 commits September 4, 2023 00:15
@Frizi
add vue ide project files
f3a4bb2
@Frizi
rename gui2 folder
e8360d7
@Frizi
cleanup
e3a07dd
@Frizi
cleanup
f8d9d91
@Frizi
do not react to keypress when editing text
8451e79
@Frizi
update codeowners
d249222
@somebody1234
wip: (broken) begin porting visualizations to vue
f67fd2f
@somebody1234
Restore circular menu from other branch; move visualizations to separ…
d186dcd 
…ate directory
@somebody1234
Use Visualization component in visualizations; try to figure out ho…
f634a66 
…w to dynamically import components
@somebody1234
Remove scoped styles
64acf2c 
Vue supports `style scoped`.
@somebody1234
Merge branch 'develop' into wip/sb/gui2-viz-vue-port
2aba41b
@somebody1234
Add fullscreen button; begin fullscreen functionality
fef0d20
@somebody1234
Fix fullscreen visualization
1bcb6d1
@somebody1234
Add width/height/fullscreen props to all visualizations
ad8ac66
@somebody1234
Make visualization ref typesafe in GraphNode
c1f9cd1
@somebody1234
Hide visualization by default
6c75b42
@somebody1234
Add undefined to width/height prop
6fb234e
@somebody1234
Transparently pass through props
33b5a9e
@somebody1234
Add visualizationTypes ref
5806867
@somebody1234
Implement visualization selector
af41845
@somebody1234
Fix caching visualizations
d9d2672
@somebody1234
Change how visualizations are registered (tentative)
35717bf
@somebody1234
Fix some lints
2341d9c
@somebody1234
Switch to new visualization format
913b82f
@somebody1234
Merge branch 'develop' into wip/sb/gui2-viz-vue-port
bd28a16
@somebody1234
Visualization store
028ae80
@somebody1234
Add default value for image visualization
022f6b3
@somebody1234
Move visualization names and input types to script block
254e7a4
@somebody1234
Add support for viz style and script depenndencies
2a32970
@somebody1234
Remove style dependencies
eb144fb
@somebody1234 somebody1234 requested review from Frizi and removed request for indiv0 and PabloBuchu September 29, 2023 11:19
@somebody1234
Copy link
Contributor Author

note: this is still not tested with a new build of PM, so it may be broken.

Frizi added 3 commits October 4, 2023 14:54
@Frizi
Merge branch 'develop' into wip/sb/connect-viz
525dca2
@Frizi
More robust execution context.
b8af478 
- Added stateful async queue for managing visualization registration.
- Added error handling and exponential backoff to many language server requests.
@Frizi
visualizations in node metadata
f0e27b4
@Frizi Frizi linked an issue Oct 6, 2023 that may be closed by this pull request
Make engine connections more robust against occasional timeouts #7995
Closed
somebody1234
somebody1234 commented Oct 6, 2023
View reviewed changes
app/gui2/src/components/GraphNode.vue Outdated Show resolved Hide resolved
app/gui2/src/components/VisualizationContainer.vue Outdated Show resolved Hide resolved
app/gui2/src/util/shortcuts.ts Show resolved Hide resolved
app/gui2/ydoc-server/edits.ts Outdated Show resolved Hide resolved
farmaazon
farmaazon approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@farmaazon farmaazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I''d like to see some tests of

app/gui2/shared/languageServerTypes.ts Outdated Show resolved Hide resolved
app/gui2/src/stores/project.ts Outdated Show resolved Hide resolved
app/gui2/src/util/net.ts Show resolved Hide resolved
app/gui2/src/util/net.ts Outdated Show resolved Hide resolved
@Frizi Frizi added the CI: Ready to merge This PR is eligible for automatic merge label Oct 7, 2023
@mergify mergify bot merged commit 44f2f42 into develop Oct 7, 2023
30 checks passed
@mergify mergify bot deleted the wip/sb/connect-viz branch October 7, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frizi Frizi Frizi approved these changes

@farmaazon farmaazon farmaazon approved these changes

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make engine connections more robust against occasional timeouts
3 participants
@somebody1234 @Frizi @farmaazon