Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardization of Vector.sort array access #7697

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Aug 30, 2023

Pull Request Description

Inspired by #6361 - let's use ArrayLikeXyzNode instead of InteropLibrary.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
  • All code has been tested:
    • Benchmarks are in good shape

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Aug 30, 2023
@JaroslavTulach JaroslavTulach self-assigned this Aug 30, 2023
@JaroslavTulach
Copy link
Member Author

JaroslavTulach commented Aug 31, 2023

After fixing the report generator and running

tools/performance/engine-benchmarks$ ./bench_download.py -s stdlib -b develop wip/jtulach/SortFast_6361

I can claim there are is no slowdown in stdlib benchmarks. Now running engine benchmarks (again).

For some reason:

tools/performance/engine-benchmarks$ ./bench_download.py -b develop wip/jtulach/SortFast_6361
No successful benchmarks found within period since 2023-08-18 until 2023-09-01 for branch wip/jtulach/SortFast_6361

but analyzing engine benchmark manually I don't see any regression. In fact WarningBenchmarks.sameWarningVecSum got faster by 5%, but that may be just an oscillation...

@JaroslavTulach JaroslavTulach changed the title Standardization and speeding up of Vector.sort Standardization of Vector.sort Aug 31, 2023
@JaroslavTulach JaroslavTulach changed the title Standardization of Vector.sort Standardization of Vector.sort array access Aug 31, 2023
@JaroslavTulach JaroslavTulach added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Aug 31, 2023
@JaroslavTulach JaroslavTulach added the CI: Keep up to date Automatically update this PR to the latest develop. label Sep 1, 2023
@JaroslavTulach JaroslavTulach added CI: Ready to merge This PR is eligible for automatic merge and removed CI: Keep up to date Automatically update this PR to the latest develop. labels Sep 1, 2023
@mergify mergify bot merged commit 6deaf80 into develop Sep 1, 2023
@mergify mergify bot deleted the wip/jtulach/SortFast_6361 branch September 1, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants