-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Java Enums in "case of" branches #7607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
4e6,
hubertp and
Akirathan
as code owners
August 18, 2023 08:29
JaroslavTulach
force-pushed
the
wip/jtulach/Polyglot_Fields_7551
branch
from
August 18, 2023 08:31
c0a4944
to
9ade20e
Compare
JaroslavTulach
changed the title
Wip/jtulach/polyglot fields
Allow Java Enums in case of expression
Aug 18, 2023
JaroslavTulach
changed the title
Allow Java Enums in case of expression
Allow Java Enums in case of branches
Aug 18, 2023
JaroslavTulach
commented
Aug 18, 2023
GregoryTravis
approved these changes
Aug 18, 2023
hubertp
approved these changes
Aug 21, 2023
Akirathan
approved these changes
Aug 21, 2023
engine/runtime/src/main/scala/org/enso/compiler/codegen/IrToTruffle.scala
Outdated
Show resolved
Hide resolved
engine/runtime/src/main/scala/org/enso/compiler/data/BindingsMap.scala
Outdated
Show resolved
Hide resolved
radeusgd
approved these changes
Aug 21, 2023
jdunkerley
approved these changes
Aug 21, 2023
4e6
approved these changes
Aug 21, 2023
Co-authored-by: Pavel Marek <[email protected]>
JaroslavTulach
added
the
CI: Ready to merge
This PR is eligible for automatic merge
label
Aug 21, 2023
JaroslavTulach
changed the title
Allow Java Enums in case of branches
Allow Java Enums in "case of" branches
Aug 21, 2023
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #7551 by looking up static symbols of a
JavaClass
polyglot object.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,