Add ArgumentInfo to infix argument
#7530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
added
the
CI: No changelog needed
farmaazon
requested review from
MichaelMauderer,
kazcw,
vitvakatu,
Frizi and
mwu-tow
as code owners
vitvakatu
approved these changes
Sep 20, 2023
Frizi
approved these changes
Sep 20, 2023
| @@ -1651,7 +1651,7 @@ impl<'a> TreeBuilder<'a> { | |||
| let ptr_usage = self.pointer_usage.entry(main_ptr).or_default(); | |||
| let widget_id = main_ptr.to_identity(ptr_usage); | |||
|
|
|||
| let is_placeholder = span_node.is_expected_argument(); | |||
| let is_placeholder = span_node.is_expected_argument() || span_node.is_expected_operand(); | |||
There was a problem hiding this comment.
Looks like the same change also needs to be made in list_editor.rs. Maybe there should be a is_placeholder method on the span node?
|
QA passed 🍏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Adds proper argument information to span tree. Fixes #7107
opr-placeholder-2023-09-20_15.26.39.mp4
Important Notes
Nodes where the left operand (target) is missing still does not work, because the engine still does not send us any method pointer (perhaps due to its internal design).
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.