-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing 'UTC' did not equal 'Etc/UTC' failure on Mac #7526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want the check to pass, I think you need to remove the second added line, I'm pretty sure it will fail.
Definitely good to fix CI to pass, as always failing on Mac is not good - so I'm For merging this PR.
However, I would like to not close #7505. I think we should investigate why one system returns Etc/UTC
and other just UTC
.
Apparently they seem to be different names for the same concept...
Still, I'd like us to ensure that the line I just suggested you to remove actually works in longer term:
loose_zone_equal time.zone Time_Zone.utc
As a quick fix for CI - this is fine, but for longer-term it would be worth to investigate why there is this timezone inconsistency and fix it.
As users will definitely expect the TZ returned here to == Time_Zone.utc
.
Co-authored-by: Radosław Waśko <[email protected]>
There are two more
On my Mac the tests are skipped, but not on CI... |
…s' as it fails on CI Mac OS X
Having CI green is important. I guess I merge now. @mwu-tow, can you make Mac OS X CI required again? Otherwise we are likely going to regress soon. |
Pull Request Description
Mitigates #7505 and makes sure CI passes again on our x64 based Mac OS X machines.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Enso
style guides.