-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add drop down for replace, remove Column_Selector #7295
Conversation
Add `select_blank_columns` and `remove_blank_columns`.
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Outdated
Show resolved
Hide resolved
? Blank values | ||
Blank values are `Nothing`, `""` and depending on setting `Number.nan`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like I'd sometimes want to distinguish between a ""
and Nothing
- depending on context these may have some different meaning - e.g. in database NULL
vs empty string are different entries and they can mean different things.
Do you think we should add treat_empty_string_as_blank
like treat_nan_as_blank
?
I'm not strongly attached to it since this can be emulated relatively easily using more primitive operations. So whatever you think will be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was be design when we agreed the previous API design for removing blank values.
I appreciate there is a difference but the single value case can easily be done using the filter API.
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Table_Helpers.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and the usages look much cleaner with the new approach! ❤️
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Extensions.enso
Outdated
Show resolved
Hide resolved
…ons.enso Co-authored-by: GregoryTravis <[email protected]>
Pull Request Description
replace
functions.Column_Selector
type.select_blank_columns
andremove_blank_columns
functions to table types.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.