Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not rename column on fill_nothing and add version to the Table allowing filling multiple (include fill_empty as well). #7166

Merged
merged 18 commits into from
Jul 5, 2023
Merged

Do not rename column on fill_nothing and add version to the Table allowing filling multiple (include fill_empty as well). #7166

merged 18 commits into from
Jul 5, 2023

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented Jun 29, 2023 •
edited
Loading

Pull Request Description

Updated Column.fill_nothing and .fill_empty, and added the same to Table. (Both in-memory and db.)

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@GregoryTravis GregoryTravis marked this pull request as ready for review June 29, 2023 16:54
radeusgd
radeusgd reviewed Jun 30, 2023
View reviewed changes
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Just please add the missing docs for arguments for the Table ops.

@GregoryTravis GregoryTravis requested a review from radeusgd June 30, 2023 16:18
@xvcgreg
Copy link

xvcgreg commented Jul 4, 2023

@GregoryTravis what's the holdup here?

@jdunkerley
Copy link
Member

@GregoryTravis what's the holdup here?

He was out on holiday

@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label Jul 5, 2023
@mergify mergify bot merged commit 6eb46af into develop Jul 5, 2023
@mergify mergify bot deleted the wip/gmt/6930-fill-column branch July 5, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

@radeusgd radeusgd radeusgd approved these changes

Assignees
No one assigned
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GregoryTravis @xvcgreg @jdunkerley @radeusgd