move method icon definition to documentation tag #7123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed method icon definition syntax from
Icon: icon_name
toICON icon_name
. That way we are consistent with the existing usage of doctags forALIAS
and eventuallyGROUP
, and it will be easier to automate migration to method annotations when it's time to do so (see https://github.com/orgs/enso-org/discussions/7120 for related proposal).Additionaly, I've modified the
icons
example scene, such that it is now possible to grab the icon names from there. This should serve as a reference for the libs team when assigning the icons.When using
run ide watch
script to run the electron application, that scene can be accessed through the web browser using URL http://localhost:8080/?startup.entry=iconsChecklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.