Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move method icon definition to documentation tag #7123

Merged
merged 5 commits into from
Jun 29, 2023

Conversation

Frizi
Copy link
Contributor

@Frizi Frizi commented Jun 26, 2023

Changed method icon definition syntax from Icon: icon_name to ICON icon_name. That way we are consistent with the existing usage of doctags for ALIAS and eventually GROUP, and it will be easier to automate migration to method annotations when it's time to do so (see https://github.com/orgs/enso-org/discussions/7120 for related proposal).

Additionaly, I've modified the icons example scene, such that it is now possible to grab the icon names from there. This should serve as a reference for the libs team when assigning the icons.
image

When using run ide watch script to run the electron application, that scene can be accessed through the web browser using URL http://localhost:8080/?startup.entry=icons

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just approving the Enso bit.

Copy link
Member

@wdanilo wdanilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@farmaazon
Copy link
Contributor

QA report: 🟢

Just fix the tests, as those are failing on CI.

@Frizi Frizi added the CI: No changelog needed Do not require a changelog entry for this PR. label Jun 28, 2023
@Frizi Frizi added CI: Ready to merge This PR is eligible for automatic merge CI: Keep up to date Automatically update this PR to the latest develop. labels Jun 29, 2023
@mergify mergify bot merged commit cb9d4c4 into develop Jun 29, 2023
@mergify mergify bot deleted the wip/frizi/icon-group-tag branch June 29, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Keep up to date Automatically update this PR to the latest develop. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants