Create execution context with id #6947
Conversation
4e6
added
the
CI: No changelog needed
| @@ -707,7 +707,9 @@ impl model::project::API for Project { | |||
| ) -> BoxFuture<FallibleResult<model::ExecutionContext>> { | |||
| async move { | |||
| let ls_rpc = self.language_server_rpc.clone_ref(); | |||
| let context = execution_context::Synchronized::create(ls_rpc, root_definition); | |||
| let context_id = Uuid::new_v4(); | |||
There was a problem hiding this comment.
Random UUID is created on the IDE side and send to the LS+engine to use it. That's a change to current behavior when no UUID is send and the LS+engine thinks one up. As a result the randomness is on the IDE side and the engine behaves (more) deterministically when fed with the same stream of messages.
There was a problem hiding this comment.
I think this is slightly related to #6718
| pub async fn new( | ||
| project: model::Project, | ||
| method: MethodPointer, | ||
| context_id: model::execution_context::Id, | ||
| ) -> FallibleResult<Self> { | ||
| let graph = controller::Graph::new_method(&project, &method).await?; | ||
| let execution = project.create_execution_context(method.clone()).await?; | ||
| let execution = project.create_execution_context(method.clone(), context_id).await?; |
There was a problem hiding this comment.
I would generate context ID here instead of https://github.com/enso-org/enso/pull/6947/files#diff-43cfb2975b079bdc838c391f870ff5150a1eb5807e912f5d1230432b76a5fc46R134
This is graph controller, and controller should have API "for the view". The view have no interest in generating context IDs.
Pull Request Description
executionContext/createmethod has an optionalcontext_idparameter. Supplying this argument makes the user's session more reproducible. I.e. this way the language server can recreate the user's session by recording the requests.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.