Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documenting how to obtain static methods for a type #6938

Merged
merged 4 commits into from
Jun 6, 2023
Merged

Documenting how to obtain static methods for a type #6938

merged 4 commits into from
Jun 6, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Jun 2, 2023 •
edited
Loading

Pull Request Description

Fixes #6748 by documenting how to obtain all static methods available on a Type.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Jun 2, 2023
@JaroslavTulach JaroslavTulach self-assigned this Jun 2, 2023
@enso-bot enso-bot bot mentioned this pull request Jun 3, 2023
Closed
@JaroslavTulach JaroslavTulach force-pushed the wip/jtulach/MetaStaticMethods_6748 branch from 5efe762 to dc41725 Compare June 3, 2023 06:53
hubertp
hubertp approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation looks alright

distribution/lib/Standard/Base/0.0.0-dev/src/Meta.enso Outdated Show resolved Hide resolved
test/Tests/src/Semantic/Meta_Spec.enso Show resolved Hide resolved
test/Tests/src/Semantic/Meta_Spec.enso Show resolved Hide resolved
@JaroslavTulach @hubertp
Typo
f0cc50c 
Co-authored-by: Hubert Plociniczak <[email protected]>
@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Jun 6, 2023
@mergify mergify bot merged commit f1bdcbb into develop Jun 6, 2023
@mergify mergify bot deleted the wip/jtulach/MetaStaticMethods_6748 branch June 6, 2023 08:06
@enso-bot enso-bot bot mentioned this pull request Jun 6, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd left review comments

@hubertp hubertp hubertp approved these changes

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.methods on a Type are not returning the static methods of the type.
4 participants
@JaroslavTulach @hubertp @radeusgd @GregoryTravis