Add compiler pass that discovers ambiguous imports #6868

Akirathan · 2023-05-26T16:57:36Z

Pull Request Description

Add a new compiler pass that analyses duplicated and ambiguous symbols from imports. A duplicated import is an import that imports a symbol that has already been imported by a previous import statement and that refers to the same object. An ambiguous import is an import statement that imports a symbol that has already been import by a previous import statement and refers to a different object.

For every ambiguous import, an error is provided - by replacing the IR with the IR.Error. For every duplicated import, a warning is attached to the IR.

Example of the compiler error message:

Extensions.enso[41:1-41:77]: Ambiguous imported symbol 'Codepoint_Ranges' in import statement. The original import is 'import Standard.Base.Data.Text.Text_Sub_Range.Codepoint_Ranges' in Extensions.enso[20:1-20:56]

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

The documentation has been updated, if necessary.
Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:
- Unit tests have been written where possible.
- If GUI codebase was changed, the GUI was tested when built using ./run ide build.

…us imports

…rts-not-reported # Conflicts: # engine/runtime/src/test/scala/org/enso/compiler/test/semantic/ImportExportTest.scala

This reverts commit d8693b5.

- Also make sure that all the warnings are collected.

Co-authored-by: James Dunkerley <[email protected]>

test/Tests/src/Data/Range_Spec.enso

hubertp

Some Scala code could be improved.

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Regex/Pattern.enso

distribution/lib/Standard/Base/0.0.0-dev/src/System/File.enso

engine/runtime/src/main/scala/org/enso/compiler/pass/analyse/AmbiguousImportsAnalysis.scala

hubertp · 2023-06-09T16:04:15Z

engine/runtime/src/main/scala/org/enso/compiler/pass/analyse/AmbiguousImportsAnalysis.scala

+        ) match {
+          case Left(error) => Left(List(error))
+          case Right(imp)  => Right(imp)
+        }


Similar comment as before

I am confused. Do you mean the one with fold suggestion? How should I refactor this to fold?

engine/runtime/src/main/scala/org/enso/compiler/pass/analyse/AmbiguousImportsAnalysis.scala

jdunkerley · 2023-06-13T09:16:53Z

Thanks for the changes looks much cleaner.

This reverts commit 45ffd3a.

…rts-not-reported

This reverts commit 2b49036.

Add AmbiguousImportAnalysis

7292123

Akirathan linked an issue May 26, 2023 that may be closed by this pull request

Ambiguous aliased imports not reported #6431

Closed

Akirathan added 4 commits May 31, 2023 16:12

AmbiguousImportsAnalysis distinguishes between duplicated and ambiguo…

2738138

…us imports

docs

74cd016

Merge branch 'develop' into wip/akirathan/6431-ambiguous-aliased-impo…

2590bfa

…rts-not-reported # Conflicts: # engine/runtime/src/test/scala/org/enso/compiler/test/semantic/ImportExportTest.scala

Update changelog

9f2851d

Akirathan self-assigned this May 31, 2023

Akirathan added 18 commits June 2, 2023 18:30

AmbiguousImportAnalysis uses symbol full paths to determine ambiguity

06bdbb1

Fix some tests - duplicated import is a warn, not error

1325b60

Improve compiler's diagnostic messages

d8693b5

Rename Extension.enso files

08efa41

Add some docs

c466b35

Revert "Improve compiler's diagnostic messages"

cc4a672

This reverts commit d8693b5.

Remove Sort_Direction ambiguity from Vector.enso

25f3d48

Remove temp debug logging

c952d4e

Fix multiple symbol importing.

41a0068

Improve errors collection

be394ea

- Also make sure that all the warnings are collected.

Remove URI ambiguity in HTTP.enso

6cdc63e

Remove duplicate imports

c46a4ba

Fix PassesTest

e7cbf0d

Fix hidden names case

c35f8e6

Remove duplicate imports from Standard.Table

9b00b9b

Rename Standard.Test/Extensions to Test_Extensions

6e817f6

Remove some ambiguous imports

b1e5809

Remove some duplicate imports

fdc9247

Akirathan mentioned this pull request Jun 7, 2023

Ambiguous symbol import error is too restrictive #6985

Closed

Akirathan added 2 commits June 7, 2023 16:57

Fix some imports after removals

ca7e22a

Remove some duplicate imports

c0611ac

Akirathan force-pushed the wip/akirathan/6431-ambiguous-aliased-imports-not-reported branch from 6df70b9 to c0611ac Compare June 7, 2023 14:57

Akirathan marked this pull request as ready for review June 7, 2023 15:30

Akirathan and others added 10 commits June 9, 2023 16:33

Remove some duplicates

0181c4c

Apply suggestions from code review

3103fe4

Co-authored-by: James Dunkerley <[email protected]>

Consistent naming of polyglot java imports

e1cb0ce

Hide symbols from more generic imports

5cb41fc

Move Sort_Direction from Ordering module to Data

78375fa

Use more specific imports in Std lib instead of import all

7dfdd36

Revert examples documentation

a759efd

Revert extensions module renaming

102e4f6

Move Sort_Direction from Ordering module to Data

c99b608

Fix after merge

0cca1a6

Akirathan force-pushed the wip/akirathan/6431-ambiguous-aliased-imports-not-reported branch from 3e219c3 to 0cca1a6 Compare June 9, 2023 15:25

Akirathan commented Jun 9, 2023

View reviewed changes

test/Tests/src/Data/Range_Spec.enso Outdated Show resolved Hide resolved

Specific symbols are hidden from more generic imports

2b49036

hubertp reviewed Jun 9, 2023

View reviewed changes

Remove unnecessary from.. Extensions import all statements

b36b4b8

Akirathan force-pushed the wip/akirathan/6431-ambiguous-aliased-imports-not-reported branch from ca9bcc8 to b36b4b8 Compare June 9, 2023 16:14

enso-bot bot mentioned this pull request Jun 10, 2023

@widgets for extension functions of Table may not be found #6955

Closed

Apply some PR suggestions

dd77052

jdunkerley approved these changes Jun 13, 2023

View reviewed changes

Akirathan added 6 commits June 13, 2023 12:06

Get rid of some more duplicated imports

45ffd3a

typo in docs

71e39e5

Fix builtin types test metadata

608e69e

Revert "Get rid of some more duplicated imports"

47697eb

This reverts commit 45ffd3a.

Merge branch 'develop' into wip/akirathan/6431-ambiguous-aliased-impo…

a0d2daf

…rts-not-reported

Remove unnecessary imports causing duplication warnings

354b5f3

Akirathan removed the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Jun 14, 2023

Revert "Specific symbols are hidden from more generic imports"

f291dec

This reverts commit 2b49036.

Akirathan merged commit 67821bf into develop Jun 14, 2023

Akirathan deleted the wip/akirathan/6431-ambiguous-aliased-imports-not-reported branch June 14, 2023 10:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add compiler pass that discovers ambiguous imports #6868

Add compiler pass that discovers ambiguous imports #6868

Akirathan commented May 26, 2023 •

edited

Loading

hubertp left a comment

hubertp Jun 9, 2023

Akirathan Jun 12, 2023

jdunkerley commented Jun 13, 2023

Add compiler pass that discovers ambiguous imports #6868

Add compiler pass that discovers ambiguous imports #6868

Conversation

Akirathan commented May 26, 2023 • edited Loading

Pull Request Description

Important Notes

Checklist

hubertp left a comment

Choose a reason for hiding this comment

hubertp Jun 9, 2023

Choose a reason for hiding this comment

Akirathan Jun 12, 2023

Choose a reason for hiding this comment

jdunkerley commented Jun 13, 2023

Akirathan commented May 26, 2023 •

edited

Loading