Execution control for Table.write and various widget tweaks... #6835

jdunkerley · 2023-05-24T16:26:22Z

Pull Request Description

Adds execution control to Table.write.
- Refactored the Text.write to make part reusable.
- Tidied up some legacy mess in tests.
Add easier flow to go from Text to an URI to fetching data.
Add decode functions to Response and Response_Body.
Fix issue with 0 length regex matches (using same as Python and .Net approach).
Add various ALIAS entries to make function discovery easier.
Sort a lot of drop down and vector editors out (including switch to fully qualified names).

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

The documentation has been updated, if necessary.
Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:
- Unit tests have been written where possible.
- If GUI codebase was changed, the GUI was tested when built using ./run ide build.

radeusgd · 2023-06-01T12:42:17Z

distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Widget_Helpers.enso

-    count_not_nothing = Option "Count Not Nothing" "(Aggregate_Column.Count_Not_Nothing)" [column_widget]
-    count_nothing = Option "Count Nothing" "(Aggregate_Column.Count_Nothing)" [column_widget]
+    count_not_nothing = Option "Count Not Nothing" fqn+".Count_Not_Nothing" [column_widget]
+    count_nothing = Option "Count Nothing" fqn+".Count_Nothing" [column_widget]

    ## Should be a list of Text columns only


Should we start implementing this by-type column filtering? We have all the capabilities needed to do that.

If not in this PR, I'd be happy to create a small PR for this - it's just a few lines of adjustment to get a really nice UX improvement.

Discussed with Ned and he argued against it.

Logic was more confusing for columns to vanish depending on the mode.

Hmm, I see. Well indeed maybe it would be less confusing if we chose the column first and then had a list of aggregations available for it - but that does not fit our Aggregate_Column format.

IMHO suggesting invalid columns for an aggregation is not that helpful, I don't imagine it is a problem, but if that's the recommendation.

I was thinking the same and wondered around adding a note if an unsupported type - so you would see the same set but something in brackets warning invalid for this).

Yes, I think that would be good. Or even, if we had the ability to add styling, the invalid types could be greyed out.

Also, I would move all unsupported down to the bottom, so that the first fields that show up are the supported ones. No sense in having to scroll thru unsupported fields to find a good one.

Shall we create a follow up task for this?

I think the sorting will be especially useful, and marking the not-matching ones should also be helpful. Since we don't have formatting yet, maybe we can mark them like /Shortest/?

Will add a task.

radeusgd · 2023-06-01T17:15:26Z

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Boolean.enso

@@ -15,7 +15,8 @@ type Boolean
    True
    False

-    ## Computes the logical and (conjunction) of two booleans.
+    ## ALIAS And
+       Computes the logical and (conjunction) of two booleans.


Suggested change

Computes the logical and (conjunction) of two booleans.

Computes the conjunction (logical 'and') of two booleans.

I'm wondering if that form would not be more readable? (low priority)

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Locale.enso

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Numbers.enso

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Regex/Pattern.enso

radeusgd · 2023-06-01T17:22:40Z

distribution/lib/Standard/Base/0.0.0-dev/src/Network/HTTP/Response.enso

+    content_type self =
+        response_headers = self.headers
+        content_type = response_headers.find if_missing=Nothing h-> "Content-Type".equals_ignore_case h.name
+        if content_type.is_nothing then Nothing else content_type.value


not for now, but I'm wondering if we should look for some idiom for this, like Kotlin's elvis operator:

Suggested change

if content_type.is_nothing then Nothing else content_type.value

content_type?.value

yeah would be a nice addition I think.

distribution/lib/Standard/Base/0.0.0-dev/src/Network/HTTP/Response.enso

distribution/lib/Standard/Base/0.0.0-dev/src/Network/HTTP/Response_Body.enso

distribution/lib/Standard/Table/0.0.0-dev/src/Data/Table.enso

distribution/lib/Standard/Table/0.0.0-dev/src/Excel/Excel_Workbook.enso

test/Table_Tests/src/IO/Formats_Spec.enso

radeusgd

Looks good to me.

I have some comments/suggestions. Nothing blocking, if we want to get this merged, I think it's fine to leave them for a follow-up PR. Just please let's not forget them :)

GregoryTravis · 2023-06-01T19:01:24Z

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Regex/Pattern.enso

@@ -97,7 +99,7 @@ type Pattern

       Arguments:
       - input: The text to match the pattern described by `self` against.


This could use a brief comment explaining the special handling of zero-length matches.

Remove dead argument from `select_columns`, `remove_columns` and `reorder_columns`. Add ALIAS to `remove_columns`.

Add custom drop down for `keep_unmatched`.

Add fetch to URI. Add some ALIASes (+, -, few methods).

Use fully qualified name for Encoding.

Use fully qualified names for File_Format dropdowns. Use fully qualified names for Report_Unmatched dropdowns. Use fully qualified names for aggregates and parse type dropdowns.

New test for disabled writing of tables.

Use `Math.max`.

Make Response_Body to_text more stable. Add local variable for copying to temp file.

jdunkerley force-pushed the wip/jd/table-write-100 branch 3 times, most recently from d74e525 to 1078748 Compare May 31, 2023 13:11