-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save backend type in localStorage, and automatically open projects when ready #6728
Conversation
ok re: removing |
note: I don't think swapping the order (URL params before explicitly passed options) is a good idea, which is why it's not being considered as a potential solution here. |
The first two mentioned issues should now be fixed. Haven't been able to repro the third issue for a while though |
This isn't working |
QA:
✔️ search works - now made case-insensitive
✔️ renaming project works (cloud backend) ✔️ can go back to dashboard from (QA not 100% thorough but should be more than enough for one PR?) logins: |
|
ae7b693
to
50cc4cf
Compare
just merged and am doing a bit of testing before pushing - it turns out there's an issue with trying to delete the project before it's closed - what should we do? i think the main issue is that the spinner is currently not set up to spin on closing - which isn't a bad thing, i think it would be a little confusing however this means that this issue doesn't really have a good solution (that i can think of, at least) also
might be fixed now but not 100% sure |
@somebody1234 We should grey out (disable) the |
Pull Request Description
--startup.project
option does not work with the new dashboard. #6666Important Notes
Needs a very thorough QA. There are quite a lot of changes to the state logic, so it'll take a little time to test them all:
-startup.project
+ the wrong backendScreencast
screen-recorder-wed-may-17-2023-19-03-22.mp4
Note: This recording does show a few issues:
startup.project
overrides the one passed by the dashboard. This will be fixed in the next commit(s).If anyone can reliably reproduce these problems, or can figure out the cause, that would be great. I'll see if anything can be done to simplify the state logic though (and whether the simplifications will remove the issue)
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.