Add COOP+COEP+CORP headers #6646
Conversation
|
not tested as i am currently unable to build. i'll do a reboot soon, but for now maybe @PabloBuchu could test whether this fixes the issue? |
|
never mind, build actually worked :o |
|
ok this fix doesn't work: |
somebody1234
added
the
CI: No changelog needed
somebody1234
requested review from
MichaelMauderer,
wdanilo,
farmaazon,
kazcw and
jdunkerley
as code owners
somebody1234
changed the title
|
i am getting a different error but i don't think it's related, as this is a CORS error caused by the destination URL missing CORS headers. however, the code has been here for a while and there were no problems previously, so not sure why it's a problem now |
|
correction: looks like it is caused by this change... not sure whether there's a good solution though |
|
because of the change in ide code, i think testing must not use |
|
error no longer in console. font seems to be working again: |
somebody1234
changed the title
somebody1234
force-pushed
the
wip/sb/fix-corp-header-value
branch
from
33f96c2 to
9693317
Compare
|
qa 🟢 but lets wait with merge for #6605 |
|
@wdanilo can you do the PR review here? |
|
Let's merge it! But there are some conflicts now. |
|
@PabloBuchu @somebody1234 I've got a question – how that was not noticed not watched during Q/A that when you start the app the warning is printed to console: 
Which clearly shows that it is still broken? |
|
that is a source map, which is not required to run the js script. mapbox itself should work, not sure whether there is a way to get rid of the error. i figured it would be safer to not special-case source maps, but we could explicitly allow them by setting a less restrictive CORP header maybe? |
|
but yeah, we should probably have mentioned that before merging it in... |
|
ahhh that's source map! Ok, uff ,that's much smaller than I thought. Ok, lets fix it in a separate PR then :) |
* develop: Build nightlies every day. (#6681) Force `newDashboard` default on the CI-built packages. (#6680) Verify ascribed types of parameters really exist (#6584) SuggestionBuilder needs to send ascribedType of constructor parameters (#6655) Improvements to the Table visualization. (#6653) Removing flush (#6670) Improving widgets for take/drop (#6641) disable authentication and newDashboard by default (#6664) Add COOP+COEP+CORP headers (#6646)
Pull Request Description
Fixes #6645.
Re-implements #6597, with fixes included.
Important Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.