Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change defaults for Connection.tables and ensure that Connection.query recognizes all available tables #6443

Merged
merged 12 commits into from
Apr 29, 2023
Merged

Change defaults for Connection.tables and ensure that Connection.query recognizes all available tables #6443

merged 12 commits into from
Apr 29, 2023

Conversation

radeusgd
Copy link
Member

Pull Request Description

Closes #6398

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 26, 2023
@radeusgd radeusgd changed the base branch from develop to wip/radeusgd/6326-create-database-table-from-memory April 26, 2023 18:16
@radeusgd radeusgd force-pushed the wip/radeusgd/6326-create-database-table-from-memory branch from 094b5d7 to 56fd463 Compare April 26, 2023 18:17
@radeusgd radeusgd force-pushed the wip/radeusgd/6398-fix-postgres-temporary-table-listing branch from af423cd to b2b5d46 Compare April 26, 2023 18:17
@radeusgd radeusgd force-pushed the wip/radeusgd/6326-create-database-table-from-memory branch from 56fd463 to 9c6c854 Compare April 27, 2023 09:31
@radeusgd radeusgd force-pushed the wip/radeusgd/6398-fix-postgres-temporary-table-listing branch from b2b5d46 to 78c7fcf Compare April 27, 2023 09:32
@radeusgd radeusgd force-pushed the wip/radeusgd/6326-create-database-table-from-memory branch from 9c6c854 to 4627742 Compare April 27, 2023 11:52
@radeusgd radeusgd force-pushed the wip/radeusgd/6398-fix-postgres-temporary-table-listing branch 2 times, most recently from aa2e13e to 4d6e982 Compare April 27, 2023 12:30
jdunkerley
jdunkerley approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - not quite sure what should happen on schema changes so suggest we test

@radeusgd radeusgd force-pushed the wip/radeusgd/6326-create-database-table-from-memory branch 2 times, most recently from 4ea5fe9 to 2d398aa Compare April 27, 2023 19:17
Base automatically changed from wip/radeusgd/6326-create-database-table-from-memory to develop April 27, 2023 20:06
@radeusgd radeusgd force-pushed the wip/radeusgd/6398-fix-postgres-temporary-table-listing branch from 4d6e982 to 814f618 Compare April 27, 2023 21:00
@radeusgd radeusgd requested a review from jdunkerley April 27, 2023 21:00
@radeusgd radeusgd changed the title Ensure temporary tables are included in Postgres_Connection.tables and that query works correctly. Change defaults for Connection.tables and ensure that Connection.query recognizes all available tables Apr 27, 2023
@radeusgd
Copy link
Member Author

Temporary tables show up in query selector:
image

Slightly improved schema selector for tables - allows any schema which translates to Nothing:
image
image

image
image

@radeusgd radeusgd force-pushed the wip/radeusgd/6398-fix-postgres-temporary-table-listing branch from 954cbc8 to 887f511 Compare April 28, 2023 07:29
@radeusgd radeusgd force-pushed the wip/radeusgd/6398-fix-postgres-temporary-table-listing branch from 887f511 to dad7666 Compare April 28, 2023 14:19
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Apr 28, 2023
@radeusgd radeusgd force-pushed the wip/radeusgd/6398-fix-postgres-temporary-table-listing branch from dad7666 to 2fb729f Compare April 28, 2023 22:53
@mergify mergify bot merged commit cdd0065 into develop Apr 29, 2023
@mergify mergify bot deleted the wip/radeusgd/6398-fix-postgres-temporary-table-listing branch April 29, 2023 00:13
Procrat added a commit that referenced this pull request May 2, 2023
@Procrat
Merge branch 'develop' into wip/procrat/home-button-6399
4234c47 
* develop:
  Finishing Vector Editor (#6470)
  Proper handling of multiple list views. (#6461)
  Fix disappearing cached shapes (#6458)
  Add Execution Context control to Text.write (#6459)
  Change defaults for `Connection.tables` and ensure that `Connection.query` recognizes all available tables (#6443)
Procrat added a commit that referenced this pull request May 3, 2023
@Procrat
Merge branch 'develop' into wip/procrat/json-viz-last-row-6196
b63966e 
* develop: (34 commits)
  Continued Execution Context work and some little fixes (#6506)
  IDE's logging to a file (#6478)
  Fix application config (#6513)
  Cloud/desktop mode switcher (#6448)
  Fix doubled named arguments bug (#6422)
  Reimplement `enso_project` as a proper builtin (#6352)
  Fix layer ordering between dropdown and breadcrumbs backgrounds.  (#6483)
  Multiflavor layers (#6477)
  DataflowAnalysis preserves dependencies order (#6493)
  Implement `create_database_table` for Database Table (#6467)
  Limit Dead Letter logging (#6482)
  More reliable shutdown of the EnsoContext to save resources (#6468)
  Make execution mode `live` default for CLI (#6496)
  Finishing Vector Editor (#6470)
  Proper handling of multiple list views. (#6461)
  Fix disappearing cached shapes (#6458)
  Add Execution Context control to Text.write (#6459)
  Change defaults for `Connection.tables` and ensure that `Connection.query` recognizes all available tables (#6443)
  Introducing @BuiltinMethod.needsFrame and InlineableNode (#6442)
  Hide profile button behind a feature flag (#6430)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@4e6 4e6 Awaiting requested review from 4e6

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach

@hubertp hubertp Awaiting requested review from hubertp

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Temporary Tables are not listed in connection.tables in Postgres
3 participants
@radeusgd @jdunkerley @GregoryTravis