Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution environment integration fixes. #6434

Merged

Conversation

MichaelMauderer
Copy link
Contributor

@MichaelMauderer MichaelMauderer commented Apr 26, 2023

Pull Request Description

Follow up to #6341 (comment) . Contains some refactoring and solves some left over to-dos in the code.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@MichaelMauderer MichaelMauderer added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 26, 2023
@MichaelMauderer MichaelMauderer self-assigned this Apr 26, 2023
@MichaelMauderer MichaelMauderer marked this pull request as ready for review April 26, 2023 14:41
@vitvakatu
Copy link
Contributor

QA Report 🔴

Shortcuts change the visual state of the dropdown but do not switch the execution environment. No messages to the engine and icons on nodes are not updated.

@MichaelMauderer
Copy link
Contributor Author

QA Report red_circle

Shortcuts change the visual state of the dropdown but do not switch the execution environment. No messages to the engine and icons on nodes are not updated.

This was a bug ion the dropdown not updating its output when using the FRP API to override the selection. Urgh. Should be fixed now.

@vitvakatu
Copy link
Contributor

QA Passed 🟢

@MichaelMauderer MichaelMauderer added the CI: Ready to merge This PR is eligible for automatic merge label Apr 27, 2023
@vitvakatu vitvakatu removed the CI: Ready to merge This PR is eligible for automatic merge label Apr 27, 2023
@vitvakatu vitvakatu added the CI: Ready to merge This PR is eligible for automatic merge label Apr 27, 2023
@vitvakatu
Copy link
Contributor

Fixed recently spotted an issue with the environment name in generated code and retested the whole thing.

@mergify mergify bot merged commit 233bf86 into develop Apr 27, 2023
@mergify mergify bot deleted the wip/MichaelMauderer/Execution_Environment_Integration_Fixes branch April 27, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants