-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve inlining of <|
on (GraalVM EE)
#6384
Merged
+70
−48
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ebf5b8b
Benchmark for <| function
JaroslavTulach df80b2c
Define <|, << and >> in Function
JaroslavTulach f03aba6
Assume UnresolvedSymbol can convert to Function and dispatch to its m…
JaroslavTulach 5ffa216
Enough to search for UnresolvedSymbol functions in Function
JaroslavTulach 150cc85
Clone each builtin before use to speed cascade of <| up
JaroslavTulach 2188140
Try harder to inline cloned BuildinRootNode call target
JaroslavTulach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Clone each builtin before use to speed cascade of <| up
commit 150cc85cc797f1c1d2a38eaf0f2d1e1bda77ed0c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cloning each
BuiltinRootNode
before use - builtins are lightweight and cloning helps to overcome Truffle recursive inlining limit.Builtins that don't require
VirtualFrame
in their method signature are explicitly inlined by #6255 (comment) - those that requireVirtualFrame
are "cloned" before each use. That makes Truffle believe that each call into the builtin is a call the different function.Such a cloning is not as effective direct inlining, but certainly more effective than giving up on inlining completely due to recursive limit for inlining.