Change order of arguments when controlling context #6357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/orgs/enso-org/discussions/6344 requested to change the order of arguments when controlling context permissions. This brings is closer to the design doc but also a bit cumbersome to use (see changed tests) which don't play well with default arguments.
hubertp
requested review from
jdunkerley,
radeusgd,
4e6 and
JaroslavTulach
as code owners
hubertp
added
the
CI: No changelog needed
4e6
approved these changes
Apr 19, 2023
jdunkerley
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Thanks for this @hubertp - hopefully we can try it in anger soon and then we can revisit if we need to.
radeusgd
reviewed
Apr 19, 2023
Comment on lines
-181
to
+182
| with_enabled_context : Context -> Function -> Text -> Any | ||
| with_enabled_context context ~action environment=Runtime.current_execution_environment = with_enabled_context_builtin context action environment | ||
| with_enabled_context : Context -> Text -> Function -> Any | ||
| with_enabled_context context environment=Runtime.current_execution_environment ~action = with_enabled_context_builtin context environment action |
There was a problem hiding this comment.
If the default is not last, is there any reason to keep the default?
There was a problem hiding this comment.
You can still invoke with a named action argument and make use of the default (see one of tests). I'm happy to adapt it, obviously, depending on how things develop during testing of execution contexts.
JaroslavTulach
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
https://github.com/orgs/enso-org/discussions/6344 requested to change the order of arguments when controlling context permissions.
Important Notes
The change brings it closer to the design doc but IMHO also a bit cumbersome to use (see changed tests) - applications involving default arguments don't play well when the last argument is not the default 🤷 .`
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.