-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid NullPointerException in --dumpGraphs & test & docs #6304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After integration of #6255 the following command no longer works:
it yields
This is caused by our adventurous subclassing of |
Akirathan
approved these changes
Apr 17, 2023
hubertp
approved these changes
Apr 17, 2023
JaroslavTulach
added
the
CI: No changelog needed
Do not require a changelog entry for this PR.
label
Apr 17, 2023
JaroslavTulach
force-pushed
the
wip/jtulach/NPE_DumpGraphs
branch
from
April 17, 2023 11:46
1206905
to
9246ce1
Compare
JaroslavTulach
changed the title
Avoid NullPointerException in --dumpGraphs
Avoid NullPointerException in --dumpGraphs & test & docs
Apr 17, 2023
4e6
approved these changes
Apr 17, 2023
radeusgd
reviewed
Apr 18, 2023
...nterpreter-dsl-test/src/test/java/org/enso/interpreter/dsl/test/InliningBuiltinsOutNode.java
Show resolved
Hide resolved
JaroslavTulach
added a commit
that referenced
this pull request
Apr 18, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
--bug
Type: bug
--low-performance
CI: No changelog needed
Do not require a changelog entry for this PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Additional bugfix for #5709 with an improved documentation and test for
@BuiltinMethod
and its processor.Checklist
Java,