Ensure new and wrapper nodes inherit UUID #6067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertp
force-pushed
the
wip/hubert/6045-missing-suggestions-for-values-with-warnings
branch
from
69898f8 to
461306a
Compare
hubertp
force-pushed
the
wip/hubert/6045-missing-suggestions-for-values-with-warnings
branch
from
e5281b9 to
ab2493a
Compare
JaroslavTulach
approved these changes
Mar 27, 2023
...ime-with-instruments/src/test/java/org/enso/interpreter/test/NodeCountingTestInstrument.java
Outdated
Show resolved
Hide resolved
Instrumentation of calls involving warning values never really worked because: 1) newly created nodes didn't set the UUID of their instrumentable children 2) the instrumentable wrappers always had an empty (i.e. null) UUUID and they never referred get/setId to their delegates On the surface, everything worked fine. xcept when one actually relied on the instrumentation of values with warnings. Then no instrumentation (replacement of nodes) was performed due to empty UUID (as required by `hasTag` of `FunctionCallInstrumentationNode`).
Added a test that mimicks IdExecutionInstrument by essentially recording all function calls. Previously this test would fail because the new node would be missing `UUID` and `FunctionCallInstrumentationNode` would not be replaced by its wrapper, `FunctionCallInstrumentationNodeWrapper`.
Merged two test instrumentation services to avoid the problem with separate compilation. So far we deal with it by having a subproject per instrumentation. This looked like an overkill for those tests.
hubertp
force-pushed
the
wip/hubert/6045-missing-suggestions-for-values-with-warnings
branch
from
ab2493a to
5cbe8fe
Compare
…alues-with-warnings
…alues-with-warnings
mergify
bot
deleted the
wip/hubert/6045-missing-suggestions-for-values-with-warnings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Instrumentation of calls involving warning values never really worked because:
they never referred
get/setIdcalls to their delegatesOn the surface, everything worked fine. Except when one actually relied on the instrumentation of values with warnings for proper setup. Then no instrumentation (replacement of nodes) was performed due to empty UUID (as required by
hasTagofFunctionCallInstrumentationNode).Closes #6045. Discovered in #5893.
Screenshot
After the change, as expected:
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.