Use AG Grid instead of the old table.js rendering

[jdunkerley]

Pull Request Description

Expanded view:

Truncated view:

Replaces the code generating the JS Table visualization with AG Grid Community.

• Supports all of the inputs from the old table.js support.
• Consistently renders values regardless of source.
• No support for nested tables - by design, we can assess value later.
• Grid allows sorting and filtering.
• Pins the header row.
• Alternate row coloring.

Important Notes

To switch to the Enterprise edition, we would need to solve the licensing issues. This would add:

• Filter with values in the grid (like Excel).
• Column auto-sizing.
• Column pining.
• Clipboard copy support (subject to solving the electron issue) - including with or without headers.
• Ability to export to Excel and CSV from the grid.
• Column selector.
• Better options for larger datasets (community only supports infinite scroll).

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• The documentation has been updated, if necessary.
• Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
• All code follows the
  Scala,
  Java,
  and
  Rust
  style guides. In case you are using a language not listed above, follow the Rust style guide.
• All code has been tested:
  • Unit tests have been written where possible.
  • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

[farmaazon]

I hope you haven't spent too much time on it, as the table visualization will be replaced anyway in #5806 with a completely different take on rendering tables. I don't think it's compatible with AG Grid. Surely, we cannot rely on its filtering/sorting, as those need cooperation with the engine.

[jdunkerley]

I hope you haven't spent too much time on it, as the table visualization will be replaced anyway in #5806 with a completely different take on rendering tables. I don't think it's compatible with AG Grid. Surely, we cannot rely on its filtering/sorting, as those need cooperation with the engine.

A small piece of work to get closer to the functionality we need for now. Once the rust-based grids can do everything we need we can swap.

Filtering and sorting indeed is limited to only the cases when we show the whole set.
The server-side data options might enable this on larger sets later.

[radeusgd]

For a long time I was thinking that it may be easiest to visualize objects by their to_text/to_display_text representation - what is the benefit on relying on JSON for the cell contents? So I'm thinking if the new Date handling is needed - IMO we should just rely on our Text representation.

As for the 1-indexed rows - OK, but let's add a note to the documentation of places where there will now be inconsistency.

Looks good overall, cool that we are getting this cool table vis!

Approving, but please make sure we are not displaying a wrong timezone on the date visualization - this is something that I think we must avoid.

[jdunkerley]

Filtering and sorting indeed is limited to only the cases when we show the whole set.

The grid will disable filter/sort if the row set is truncated (1000 rows limit currently). There will also be a pinned row added to tell the user this and the total row count.

[wdanilo]

Just a note here. Nothing to fix here, as we are doing it wrongly in other places as well, but basically this is bad, as it makes the app not working without internet connection. We need to fix this and other similar places one day. CC @sylwiabr