AI Completions #5910
Merged
AI Completions #5910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kustosz
requested review from
jdunkerley,
radeusgd,
4e6,
JaroslavTulach,
hubertp,
MichaelMauderer,
wdanilo,
farmaazon,
mwu-tow and
kazcw
as code owners
wdanilo
approved these changes
Mar 14, 2023
app/gui/src/controller/searcher.rs
Outdated
Comment on lines
291
to
303
| // If there isn't any expression part, the pattern is the whole input. | ||
| // If there isn't any expression part, the pattern is the whole input. |
There was a problem hiding this comment.
I believe this is an accidental change :)
| const AI_STOP_SEQUENCE: &'static str = "`"; | ||
| const AI_GOAL_PLACEHOLDER: &'static str = "__$$GOAL$$__"; | ||
|
|
||
| async fn accept_ai_query( |
There was a problem hiding this comment.
I know this is PoC, but docs are needed here for future refactoring/development. Please describe shortly what this function does and why.
| Ok(()) | ||
| } | ||
|
|
||
| fn handle_ai_query(&self, query: String) -> FallibleResult { |
There was a problem hiding this comment.
I know this is PoC, but docs are needed here for future refactoring/development. Please describe shortly what this function does and why.
2 tasks
hubertp
approved these changes
Apr 4, 2023
# Conflicts: # CHANGELOG.md # app/gui/src/controller/searcher.rs # engine/language-server/src/main/scala/org/enso/languageserver/boot/MainModule.scala # engine/language-server/src/main/scala/org/enso/languageserver/data/Config.scala # engine/language-server/src/test/scala/org/enso/languageserver/boot/resource/RepoInitializationSpec.scala # engine/language-server/src/test/scala/org/enso/languageserver/filemanager/ContentRootManagerSpec.scala # engine/language-server/src/test/scala/org/enso/languageserver/runtime/ContextEventsListenerSpec.scala # engine/language-server/src/test/scala/org/enso/languageserver/search/SuggestionsHandlerSpec.scala # engine/language-server/src/test/scala/org/enso/languageserver/websocket/binary/BaseBinaryServerTest.scala # engine/language-server/src/test/scala/org/enso/languageserver/websocket/json/BaseServerTest.scala # engine/language-server/src/test/scala/org/enso/languageserver/websocket/json/FileManagerTest.scala # engine/language-server/src/test/scala/org/enso/languageserver/websocket/json/VcsManagerTest.scala
|
@kustosz please take a look at this PR |
|
Ok @xvcgreg @sylwiabr this is ready for QA according to Marcin :) To test it, you need |
|
QA: passed 🍏 : |
|
Perfect! It has landed <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Added a special escape hatch in the searcher to run AI completions. Screencast was posted previously on discord. You'll need to export
OPENAI_API_KEYto use the feature, otherwise it's a no-op. Currently only works with tables, more prompts need to be written. Also a few new issues opened to enable nicer prompts in the future.Important Notes
The whole searcher-side of things is a mess and it's only a PoC, so don't spend too much time reviewing it, think about how to make it a feature instead :P
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.