-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cross_tab
column naming edge cases, add fill_empty
#5863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoryTravis
approved these changes
Mar 8, 2023
jdunkerley
approved these changes
Mar 9, 2023
radeusgd
force-pushed
the
wip/radeusgd/common-polyglot-core-utils
branch
from
March 9, 2023 10:12
8e077e2
to
db6b824
Compare
radeusgd
force-pushed
the
wip/radeusgd/common-polyglot-core-utils
branch
from
March 9, 2023 10:14
db6b824
to
89bf974
Compare
radeusgd
force-pushed
the
wip/radeusgd/5151-cross-tab-unique-naming
branch
from
March 9, 2023 10:19
c43ec1e
to
e40c39e
Compare
radeusgd
force-pushed
the
wip/radeusgd/common-polyglot-core-utils
branch
from
March 10, 2023 23:11
89bf974
to
dbbf4ef
Compare
… no longer returns a Boolean but a Column...
radeusgd
force-pushed
the
wip/radeusgd/5151-cross-tab-unique-naming
branch
from
March 10, 2023 23:29
e40c39e
to
b854770
Compare
Base automatically changed from
wip/radeusgd/common-polyglot-core-utils
to
develop
March 11, 2023 09:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #5151 and adds some additional tests for
cross_tab
that verify duplicated and invalid names.I decided that for empty or
Nothing
names, instead of replacing them withColumn
and implicitly losing connection with the value that was in the column, we should just error on such values.To make handling of these easier,
fill_empty
was added allowing to easily replace the empty values with something else.Also,
{is,fill}_missing
was renamed to{is,fill}_nothing
to align withFilter_Condition.Is_Nothing
.Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide build
.