-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a common-polyglot-core-utils
project
#5855
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
added
the
CI: No changelog needed
Do not require a changelog entry for this PR.
label
Mar 8, 2023
radeusgd
requested review from
jdunkerley,
4e6,
JaroslavTulach and
hubertp
as code owners
March 8, 2023 12:48
JaroslavTulach
approved these changes
Mar 8, 2023
radeusgd
force-pushed
the
wip/5583-database-column-names-review
branch
from
March 8, 2023 13:22
3b95fa0
to
04157df
Compare
radeusgd
force-pushed
the
wip/radeusgd/common-polyglot-core-utils
branch
from
March 8, 2023 13:22
d8d5709
to
349e767
Compare
Akirathan
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add package-info.java
to lib/scala/common-polyglot-core-utils/src/main/java/org/enso/polyglot/common_utils
and copy some of the description in this PR there? Could be a useful future reference.
hubertp
approved these changes
Mar 8, 2023
GregoryTravis
approved these changes
Mar 8, 2023
radeusgd
force-pushed
the
wip/radeusgd/common-polyglot-core-utils
branch
from
March 8, 2023 16:44
af2e4d3
to
1af3d14
Compare
radeusgd
force-pushed
the
wip/5583-database-column-names-review
branch
from
March 8, 2023 20:27
6c0fd58
to
ac854e6
Compare
radeusgd
force-pushed
the
wip/radeusgd/common-polyglot-core-utils
branch
from
March 8, 2023 20:27
1af3d14
to
8e077e2
Compare
jdunkerley
approved these changes
Mar 9, 2023
radeusgd
force-pushed
the
wip/5583-database-column-names-review
branch
from
March 9, 2023 10:12
ac854e6
to
55f0611
Compare
radeusgd
force-pushed
the
wip/radeusgd/common-polyglot-core-utils
branch
2 times, most recently
from
March 9, 2023 10:14
db6b824
to
89bf974
Compare
radeusgd
force-pushed
the
wip/5583-database-column-names-review
branch
from
March 10, 2023 08:31
3443b75
to
cd99809
Compare
Base automatically changed from
wip/5583-database-column-names-review
to
develop
March 10, 2023 19:08
radeusgd
force-pushed
the
wip/radeusgd/common-polyglot-core-utils
branch
from
March 10, 2023 23:11
89bf974
to
dbbf4ef
Compare
5 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: No changelog needed
Do not require a changelog entry for this PR.
CI: Ready to merge
This PR is eligible for automatic merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Adds a common project that allows sharing code between the
runtime
andstd-bits
.Due to classpath separation and the way it is compiled, the classes will be duplicated - we will have one copy for the
runtime
classpath and another copy as a small JAR forStandard.Base
library.This is still much better than having the code duplicated - now at least we have a single source of truth for the shared implementations.
Due to the copying we should not expand this project too much, but I encourage to put here any methods that would otherwise require us to copy the code itself.
This may be a good place to put parts of the hashing logic to then allow sharing the logic between the
runtime
and theMultiValueKey
in theTable
library (cc: @Akirathan).Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide build
and./run ide watch
.