Implement fix for duplicate entries in visualisation list. #5808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelMauderer
added
the
CI: No changelog needed
MichaelMauderer
force-pushed
the
wip/MichaelMauderer/Remove_Duplicate_Entries_From_Default_Visualisations
branch
from
f54017b to
b4e2f26
Compare
farmaazon
approved these changes
Mar 6, 2023
Comment on lines
73
to
77
| for vis in vis_for_any { | ||
| if !result.contains(vis) { | ||
| result.push(vis.clone_ref()); | ||
| } | ||
| } |
There was a problem hiding this comment.
We may easily speed it up by keeping hash set of paths. AFAIK the path identifies the visualization.
farmaazon
approved these changes
Mar 7, 2023
MichaelMauderer
added
the
CI: Ready to merge
…ies_From_Default_Visualisations
…ies_From_Default_Visualisations
…ies_From_Default_Visualisations
…ies_From_Default_Visualisations
mergify
bot
deleted the
wip/MichaelMauderer/Remove_Duplicate_Entries_From_Default_Visualisations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes duplicate entries in the visualization chooser. The issue was caused by entries added twice, once matching the
Anytype and once matching the concrete type. Closes #5708.Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.