Review File/Data read and read_text warnings #5799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdunkerley
approved these changes
Mar 2, 2023
radeusgd
added
the
CI: No changelog needed
radeusgd
force-pushed
the
wip/radeusgd/5113-data-read-review-warnings
branch
from
e94f77a to
5a4af70
Compare
GregoryTravis
approved these changes
Mar 2, 2023
|
|
||
| ## Indicates that the given file is corrupted, i.e. the data it contains | ||
| is not in the expected format. | ||
| Corrupted_Format (file : File) (message : Text) (cause : Any | Nothing = Nothing) |
There was a problem hiding this comment.
Does Any not include Nothing? Just curious.
There was a problem hiding this comment.
It does, you are correct.
We sometimes use the Any | Nothing pattern to reinforce that a Nothing value is allowed here and it has some a bit special meaning.
How I'd read this signature is that the cause may or may not be present (| Nothing) and it may be of Any type (if it's present).
From typelevel perspective, just Any would suffice, but this is supposed to serve as kind of documentation.
I'm open to revising this approach though.
There was a problem hiding this comment.
No I think it makes sense to write it this way.
radeusgd
force-pushed
the
wip/radeusgd/5113-data-read-review-warnings
branch
from
9926016 to
29f7e61
Compare
Test warnings on file read encoding.
…heck to Enso File.
radeusgd
force-pushed
the
wip/radeusgd/5113-data-read-review-warnings
branch
from
11eb902 to
adf499b
Compare
JaroslavTulach
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #5113
Fixes a bug where read-only files would be overwritten if File.write was used in backup mode, and added tests to avoid such regression. To implement it, introduced a
is_writableproperty onFile.Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.