-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Named arguments support in IDE #5774
Conversation
b438276
to
ac1c90a
Compare
1c1b545
to
5568c13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is easy to read, has beautiful comments with explanations and I do not have any comments to the code really. Needs QA, but beside that, it's very nice!
QA reportI noticed two issues that may or may not be regressions. Colors of edges seem to be randomNotice the color of the 2023-03-09.00-39-48.mp4Clicking on the output port creates an edgeI connected the first edge, then I clicked on another node's output port – and you can see what happened on the video. After that, clicking on output ports and dragging edges produces weird results without much pattern. Sometimes I even couldn't drop the connection without connecting it to anything. It happens even after reopening the project. 2023-03-09.00-43-18.mp4Config
|
@vitvakatu amazing job with finding the issues! |
@vitvakatu I have reproduced both of those issues on current develop. Those are not introduced in this PR. port-click-edge-bug.mp4The reproduction indeed seems a bit random. The edge coloring bug is fairly easy to trigger. The one when clicks cause edges to be modified or added required some more fiddling. I randomly connected and moved things around. After a while, clicking on ports started causing weird behaviours. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA accepted. The spotted regressions will be reported as issues by me.
Pull Request Description
Added support for named arguments in IDE.
named-arg.mp4
Named arguments are now recognized in node expressions. The function argument placeholders are rendered around series of named arguments. Insertion and deletion of arguments either by connection dragging or by widget selection will cause arguments around to be rewritten into appropriate form, such that the meaning of the expression doesn't change. We no longer need to introduce any wildcards (
_
) in argument positions when editing an argument list of a resolved method.For unresolved function calls, the old behaviour remains, as we don't have data about argument names or their desired order.
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide build
and./run ide watch
.