Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception message may not be specified #5715

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Exception message may not be specified #5715

merged 3 commits into from
Feb 22, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Feb 21, 2023 •
edited
Loading

Pull Request Description

Getting ready for null values in WSLogMessage. Closes #5683.

Checklist

Please include the following checklist in your PR:

  • All code conforms to the
    Scala,
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 21, 2023
@JaroslavTulach JaroslavTulach self-assigned this Feb 21, 2023
hubertp
hubertp approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, otherwise lgtm

...ging-service/src/main/scala/org/enso/loggingservice/internal/DefaultLogMessageRenderer.scala
@@ -70,5 +70,6 @@ class DefaultLogMessageRenderer(printExceptions: Boolean)
case LogLevel.Debug => "debug"
case LogLevel.Trace => "trace"
case LogLevel.Off => "off"
case _ => "error";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's necessary since the pattern match here is exhaustive

Copy link
Member Author

@JaroslavTulach JaroslavTulach Feb 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exhaustive, except not covering null. However you are right, that's not where the #5683 exception comes from.

@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Feb 22, 2023
@enso-bot enso-bot bot mentioned this pull request Feb 22, 2023
Closed
2 tasks
@mergify mergify bot merged commit dfea59c into develop Feb 22, 2023
@mergify mergify bot deleted the wip/jtulach/WSMessage_NPE_5683 branch February 22, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertp hubertp hubertp approved these changes

@radeusgd radeusgd Awaiting requested review from radeusgd

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE in io.circe.Printer$PrintingFolder.onString from Client.processMessage(
2 participants
@JaroslavTulach @hubertp