-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match component browser entries by alias #5678
Conversation
…m:enso-org/enso into wip/galin-enso/cb-searching-by-alias-5340
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are aliases scored lower than exact matches? If we have alias foo
and exact match foo
, the exact match should score higher
Good point, at the moment the match scoring is the same. Only if they score exactly the same the exact match will take precedence over the alias. I'll add a factor to reduce the alias match score by. |
…m:enso-org/enso into wip/galin-enso/cb-searching-by-alias-5340
QA Passed. |
Pull Request Description
Closes #5340
This PR adds matching searched component browser entries by alias. Now the searcher input is also matched to the
ALIAS
tags of a component, and the best match is used for filtering and sorting the components in the component browser. The alias match scores are reduced by a factor to give them a lower priority when sorting filtered entries in the component browser.Multiple aliases for a single entry can be obtained from either multiple
ALIAS
tags in the documentation, or comma-separated aliases inside oneALIAS
tag.When the searcher input matches one of the entry's aliases the entry in the component browser is displayed as
alias (label)
.unknown_2023.02.22-09.57_1.mp4
Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide build
and./run ide watch
.