-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GraalVM to 22.3.1 #5602
Update GraalVM to 22.3.1 #5602
Conversation
Yup, that needs clean build. |
c437909
to
f9729d8
Compare
a918330
to
0b2ba68
Compare
0b2ba68
to
b97b372
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So good to see this workaround gone! 🎉
I assume you have tested that the new build works as expected in Chrome Inspector? Because I think we didn't have unit tests for it, so definitely would be good to verify if the fix was enough.
I have verified that on debugging
|
Ah sorry! I missed that. Looks amazing then 😁 |
engine/runtime/src/test/java/org/enso/interpreter/test/DebuggingEnsoTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
200 hacky lines deleted! Nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Pull Request Description
Updates the engine to GraalVM 22.3.1 version, which contains fixes for:
Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide build
and./run ide watch
.