Lookup method pointers in IDE #5578
Conversation
4e6
added
the
CI: No changelog needed
4e6
requested review from
JaroslavTulach,
hubertp,
MichaelMauderer,
wdanilo,
farmaazon and
mwu-tow
as code owners
| let method_pointer = node_info.method_call.as_ref().ok_or(NoResolvedMethod(node))?; | ||
| Ok(Rc::new(method_pointer.clone())) |
There was a problem hiding this comment.
I'd like to avoid this clone: let's store the method pointer in the ComputedValueInfo under Rc.
| @@ -324,7 +324,7 @@ interface ExpressionUpdate { | |||
| /** | |||
| * The updated pointer to the method call. | |||
| */ | |||
| methodPointer?: SuggestionId; | |||
| methodPointer?: MethodPointer; | |||
There was a problem hiding this comment.
This is the (major) API change: Instead of using SuggestionId to identify a method, we are using MethodPointer.
|
|
||
| } | ||
| .pipeTo(sessionRouter) | ||
| val computedExpressions = expressionUpdates.map { update => |
There was a problem hiding this comment.
The code is simplified. Instead of trying to find a suggestion id we just send a tripple (module, type, methodname)
| * @param profilingInfo profiling information about the expression | ||
| * @param fromCache whether or not the expression's value came from the cache | ||
| * @param payload an extra information about the computed value | ||
| */ | ||
| case class ExpressionUpdate( | ||
| expressionId: UUID, | ||
| `type`: Option[String], | ||
| methodPointer: Option[Long], | ||
| methodPointer: Option[MethodPointer], |
There was a problem hiding this comment.
This will probably increase the size of ExpressionUpdate messages - instead of a number we send the tripple with three strings, right?
There was a problem hiding this comment.
Yes, the MethodPointer is a triple containing module, self type, and method name
| } | ||
| } | ||
|
|
||
| def toProtocolMethodPointer(methodPointer: Api.MethodPointer): MethodPointer = |
There was a problem hiding this comment.
Shouldn't ContextEventsListener just make that method public (or protected, if sufficient)?
That would eliminate duplicate method.
Pull Request Description
Closes #5036
Move the logic that looks up method pointers from the language server to IDE. This way we can keep the suggestion updates and expression updates async, otherwise it will hurt the initial startup time of LS.
Fixes the issue when some expression updates does not contain the method pointer.
Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.