-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write the log in XML format suitable for VisualVM 'UI Actions' #4110
Conversation
private lazy val fmt = { | ||
Files.write( | ||
path, | ||
"<?xml version='1.0'?>\n<records>".getBytes(StandardCharsets.UTF_8), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@4e6, is it OK to just switch the format to XML? Or do we rely on the original format somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the CSV output can be used by IDE profiling. Maybe we should ask @kazcw or @MichaelMauderer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kazcw, @MichaelMauderer can you take a look? I am not aware of any (finished) attempt to merge the IDE and engine logging together, but I may not have the overall picture. CCing @xvcgreg...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have these steps documented, please?
3f393ce
to
9a9a7bb
Compare
9a9a7bb
to
27fcd06
Compare
Here is the documentation for your consideration, @hubertp. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation looks good, thanks!
Pull Request Description
Start
project-manager
with following options to provide first 20s of the startup sequence:once the
start.log
andstart.npss
files are generated (next to each other), open them in GraalVM's VisualVM:analyze.
Checklist
Please include the following checklist in your PR:
Scala,
Java,
style guides.