Add Table.cross_join and Table.zip to In-Memory Table #4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
force-pushed
the
wip/radeusgd/table-cross-join-184239059
branch
from
c980026 to
02571b9
Compare
radeusgd
changed the title
radeusgd
force-pushed
the
wip/radeusgd/table-cross-join-184239059
branch
from
02571b9 to
5ebec5e
Compare
radeusgd
force-pushed
the
wip/radeusgd/table-cross-join-184239059
branch
4 times, most recently
from
e9ac947 to
2751525
Compare
jdunkerley
approved these changes
Jan 23, 2023
| for (int i = 0; i < this.rowCount(); i++) { | ||
| if (!matchedLeftRows.contains(i)) { | ||
| leftRows.add(i); | ||
| rightRows.add(Index.NOT_FOUND); | ||
| leftUnmatchedBuilder.addRow(i, Index.NOT_FOUND); |
There was a problem hiding this comment.
could we not just add to resultsToKeep?
There was a problem hiding this comment.
resultsToKeep is an aggregator for JoinResults that later will be merged.
The idea is that the JoinResult.Builder is building an array of primitives (to avoid unnecessary boxing of integers).
I guess I could rewrite this to use a single JoinResult.Builder for the three sub-operations, if you think it is worth it.
| for (int i = 0; i < right.rowCount(); i++) { | ||
| if (!matchedRightRows.contains(i)) { | ||
| leftRows.add(Index.NOT_FOUND); | ||
| rightRows.add(i); | ||
| rightUnmatchedBuilder.addRow(Index.NOT_FOUND, i); |
std-bits/table/src/main/java/org/enso/table/data/table/join/CrossJoin.java
Show resolved
Hide resolved
…ficient approach for indices
radeusgd
force-pushed
the
wip/radeusgd/table-cross-join-184239059
branch
from
2751525 to
a31b8c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Implements https://www.pivotaltracker.com/story/show/184239059
Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.