Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach visualizations to sub-expressions #4048

Merged
merged 7 commits into from
Jan 16, 2023
Merged

Attach visualizations to sub-expressions #4048

merged 7 commits into from
Jan 16, 2023

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Jan 13, 2023

Pull Request Description

Add ability to attach visualizations to sub-expressions.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@4e6 4e6 self-assigned this Jan 13, 2023
@4e6 4e6 changed the title Attach visualization to sub-expressions Attach visualizations to sub-expressions Jan 13, 2023
JaroslavTulach
JaroslavTulach approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearly the new tests demonstrate that we cover some new situations. E.g. this PR is an improvement.

...language-server/src/main/scala/org/enso/languageserver/runtime/ContextRegistryProtocol.scala Show resolved Hide resolved
...ne/language-server/src/main/scala/org/enso/languageserver/runtime/RuntimeFailureMapper.scala Show resolved Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/EnsoContext.java Show resolved Hide resolved
engine/runtime/src/main/scala/org/enso/interpreter/instrument/job/UpsertVisualisationJob.scala Show resolved Hide resolved
engine/runtime/src/main/scala/org/enso/interpreter/instrument/job/UpsertVisualisationJob.scala Show resolved Hide resolved
engine/runtime/src/main/scala/org/enso/interpreter/instrument/job/UpsertVisualisationJob.scala Show resolved Hide resolved
@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label Jan 16, 2023
@4e6 4e6 added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Jan 16, 2023
@mergify mergify bot merged commit 0a6e623 into develop Jan 16, 2023
@mergify mergify bot deleted the wip/db/attach-visualization-184204435 branch January 16, 2023 10:19
@wdanilo wdanilo mentioned this pull request Feb 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@hubertp hubertp hubertp approved these changes

Assignees

@4e6 4e6

Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4e6 @hubertp @JaroslavTulach