Update Table API with new filter design
#3750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
force-pushed
the
wip/radeusgd/table-filter-in-memory-183389855
branch
from
f3c7c24 to
8d1cd87
Compare
jdunkerley
approved these changes
Oct 3, 2022
distribution/lib/Standard/Table/0.0.0-dev/src/Data/Filter_Condition.enso
Show resolved
Hide resolved
radeusgd
force-pushed
the
wip/radeusgd/table-filter-in-memory-183389855
branch
2 times, most recently
from
31c126f to
646e473
Compare
radeusgd
force-pushed
the
wip/radeusgd/table-filter-in-memory-183389855
branch
from
1f610e4 to
485719a
Compare
jdunkerley
approved these changes
Oct 5, 2022
| @@ -854,7 +886,7 @@ type Table | |||
| table = Examples.inventory_table | |||
| double_inventory = table.at "total_stock" * 2 | |||
| table.set "total_stock" double_inventory | |||
| set : Text -> Column.Column | Vector.Vector -> Table | |||
| set : Text -> Column | Vector.Vector -> Table | |||
There was a problem hiding this comment.
This change is wrong: Column is the module, Column.Column is the type.
But as am cleaning up a lot of this in next PR not worth blocking this merge over.
There was a problem hiding this comment.
Okay, I think I was also trying to change the imports but then reverted that and this may be a leftover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Implements https://www.pivotaltracker.com/story/show/183389855
Important Notes
Implements basic filter operations both In-Memory and for the Database backend, ensuring that existing tests can be adapted and keep working. Not all
Filter_Conditions are implemented yet.Also implements significant part of https://www.pivotaltracker.com/story/show/183390314
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.