Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Date_Period.Week to start_of and end_of methods #3733

Merged
merged 8 commits into from
Sep 23, 2022
Merged

Add Date_Period.Week to start_of and end_of methods #3733

merged 8 commits into from
Sep 23, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Sep 22, 2022 •
edited
Loading

Pull Request Description

Implements https://www.pivotaltracker.com/story/show/183349732

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@radeusgd radeusgd self-assigned this Sep 22, 2022
@radeusgd radeusgd force-pushed the wip/radeusgd/date-period-week-183349732 branch from 3251e0d to 92afc4a Compare September 23, 2022 10:57
@radeusgd radeusgd marked this pull request as ready for review September 23, 2022 11:02
jdunkerley
jdunkerley approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one suggestion (take or leave :))

std-bits/base/src/main/java/org/enso/base/time/Date_Period_Utils.java Outdated Show resolved Hide resolved
@radeusgd radeusgd force-pushed the wip/radeusgd/date-period-week-183349732 branch from ee88dc0 to 3ab60e9 Compare September 23, 2022 15:19
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Sep 23, 2022
@mergify mergify bot merged commit cd10b5d into develop Sep 23, 2022
@mergify mergify bot deleted the wip/radeusgd/date-period-week-183349732 branch September 23, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

Assignees

@radeusgd radeusgd

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeusgd @jdunkerley