Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip/wdanilo/widgets 182746060 #3678

Merged
merged 242 commits into from
Oct 4, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
242 commits
Select commit Hold shift + click to select a range
4f126b1
Refactoring
wdanilo Aug 28, 2022
00b7759
Added RangedValue impl.
wdanilo Aug 30, 2022
34dd37d
First semi-working connection to rustbuzz
wdanilo Aug 31, 2022
3b0d295
Working harfbuzz connection
wdanilo Aug 31, 2022
a3a3642
Refactoring
wdanilo Aug 31, 2022
2c3ea11
Reverting to a working version
wdanilo Sep 1, 2022
7561ee6
Refactoring
wdanilo Sep 1, 2022
15f5193
Moving bytes to usize
wdanilo Sep 1, 2022
d16297f
iCreating UBytes unit
wdanilo Sep 1, 2022
d664362
wip
wdanilo Sep 1, 2022
da24450
Refactoring
wdanilo Sep 1, 2022
7c1d378
Refactoring
wdanilo Sep 2, 2022
867d889
Adding support for non-variable fonts shaping
wdanilo Sep 2, 2022
43dd1b6
Linting
wdanilo Sep 2, 2022
bf9f5a8
Enabling cursors
wdanilo Sep 2, 2022
a7d8652
Fixing font settings
wdanilo Sep 2, 2022
e58b2d0
Refactoring
wdanilo Sep 2, 2022
4e966ae
Fixing other places in GUI using old units
wdanilo Sep 2, 2022
e8e54a7
Updating many loggers
wdanilo Sep 2, 2022
686503f
Refactoring
wdanilo Sep 2, 2022
6495b47
Cleaning loggers part 2
wdanilo Sep 2, 2022
ae78e47
Cleaning loggers part 3
wdanilo Sep 2, 2022
0509de4
Fixing wrong refactoring
wdanilo Sep 3, 2022
4edbf96
Refactoring
wdanilo Sep 3, 2022
2fdbadd
Refactoring
wdanilo Sep 4, 2022
a1e711f
Refactoring, debugging
wdanilo Sep 4, 2022
9461175
Refactoring
wdanilo Sep 5, 2022
26bc23c
Moving warns to debugs
wdanilo Sep 5, 2022
dc7d571
Refactoring
wdanilo Sep 6, 2022
d2372b7
Refactoring
wdanilo Sep 6, 2022
d2eb997
Refactoring code to compile with the new units
wdanilo Sep 6, 2022
1ad3af6
Refactoring
wdanilo Sep 6, 2022
eb68441
Refactoring
wdanilo Sep 7, 2022
a9dfd08
Introducing ViewLine unit
wdanilo Sep 7, 2022
edf5ac4
wip
wdanilo Sep 7, 2022
d57e6f1
Refactoring, ixing unit conversion errors
wdanilo Sep 7, 2022
fbc31b1
Adding optimization to redraw only changed lines
wdanilo Sep 7, 2022
33fe9bb
Refactoring
wdanilo Sep 8, 2022
dc07120
Cleaning features
wdanilo Sep 8, 2022
85be5da
Extending FRP with auto-conversion attrs
wdanilo Sep 8, 2022
d392b93
Adding a new utility for text selections
wdanilo Sep 8, 2022
d742e9e
Add generic glyph property management
wdanilo Sep 8, 2022
1c16969
Fixing lazy redraw of multiple lines bugs
wdanilo Sep 9, 2022
516dd29
Line redraw optimization
wdanilo Sep 9, 2022
6ce37ed
Working multi-line editing
wdanilo Sep 9, 2022
af547fc
Fixes, everything working
wdanilo Sep 9, 2022
387ae1e
Refactoring and documenting
wdanilo Sep 9, 2022
90f50c1
wip
wdanilo Sep 9, 2022
ebb823d
Reusing existing cursor
wdanilo Sep 9, 2022
d955dcd
Refactoring
wdanilo Sep 9, 2022
2783cd4
Refactoring
wdanilo Sep 9, 2022
5e392f1
Refactoring
wdanilo Sep 10, 2022
2895e65
Refactoring
wdanilo Sep 10, 2022
1f3c857
Moving locations from code points to byte offsets. Compiles, does not…
wdanilo Sep 11, 2022
5a3fde9
Refactoring, not working
wdanilo Sep 11, 2022
c053b4e
Fixing left/right cursor movement
wdanilo Sep 12, 2022
9f7fb13
Fixing cursor movement bugs
wdanilo Sep 12, 2022
af26c0b
Parametrizing location
wdanilo Sep 12, 2022
020153a
Fixing cursor left/right movement for unicode glyphs
wdanilo Sep 12, 2022
e37f733
Fixing up/down cursor movement for unicode glyphs
wdanilo Sep 13, 2022
12ae5ae
Moving selection to Column-based types instead of Byte-based ones. Co…
wdanilo Sep 13, 2022
28ac0ac
Fixing cursor movement after moving selection to the column type
wdanilo Sep 13, 2022
4f453cd
Refactoring
wdanilo Sep 13, 2022
b207f54
Refactoring
wdanilo Sep 13, 2022
eece7e4
Refactoring. Line shape caching disabled.
wdanilo Sep 13, 2022
670c5c1
Working lazy line shape cache update
wdanilo Sep 14, 2022
6009003
refactoring
wdanilo Sep 14, 2022
1ddecc1
Update
wdanilo Sep 14, 2022
1cdbf56
Managing default color setting
wdanilo Sep 14, 2022
71ac3b1
Cleaning
wdanilo Sep 14, 2022
23edb3e
Refactoring
wdanilo Sep 14, 2022
a4fa3b3
Refactoring
wdanilo Sep 14, 2022
8cc3839
Bugs fixing
wdanilo Sep 14, 2022
d74cfb4
Adding color animation
wdanilo Sep 14, 2022
e767aa4
Fixing an error
wdanilo Sep 14, 2022
0ba0766
Fixing bugs
wdanilo Sep 15, 2022
72cf887
Fixing bugs
wdanilo Sep 15, 2022
5c201b0
Refactoring
wdanilo Sep 15, 2022
df6434d
Refactoring code
wdanilo Sep 15, 2022
e19a4ad
Refactoring, supporting more style changes
wdanilo Sep 16, 2022
9bf75e3
New line positioning wip
wdanilo Sep 16, 2022
4a1ae4b
Improvd rendering of lines with different glyph sizes
wdanilo Sep 16, 2022
55abca0
Refactoring
wdanilo Sep 17, 2022
d499afe
Preparation for per-line y-axis animations. Wip
wdanilo Sep 17, 2022
4547c1a
Adding proper line animations
wdanilo Sep 17, 2022
423b147
Adding proper cursor size management
wdanilo Sep 17, 2022
949aba4
Cleaning
wdanilo Sep 17, 2022
49673b6
Updating selections on glyph property changes
wdanilo Sep 17, 2022
02890fe
Cleaning
wdanilo Sep 18, 2022
5a08ca9
Refactoring, before moving FRP property to option
wdanilo Sep 18, 2022
53c3f6e
Removing the "Nothing" property
wdanilo Sep 18, 2022
ae1f9cb
Refactoring
wdanilo Sep 18, 2022
dba02fa
Initial glyph modify property api
wdanilo Sep 18, 2022
da32b1c
Working computation of text height
wdanilo Sep 18, 2022
a24c297
Refactoring, before moving animation loops management from JS to Rust
wdanilo Sep 18, 2022
89e6261
Moving to Rust-based animation oop registry.
wdanilo Sep 19, 2022
88f3c94
Multiple bugs fixing, adding new animation loop handlers, moving worl…
wdanilo Sep 20, 2022
2968e9d
Fixing bugs with text width computing
wdanilo Sep 20, 2022
575c5b3
Refactoring
wdanilo Sep 20, 2022
3ec7395
Rounding y-axis line positions to integers
wdanilo Sep 20, 2022
34ce85f
Fixingwidth computation bug
wdanilo Sep 20, 2022
21139dc
Proper text area dimension refreshing
wdanilo Sep 20, 2022
d23338b
Propert handling of empty-line metrics
wdanilo Sep 20, 2022
0ad701b
Refactoring
wdanilo Sep 20, 2022
8302f8a
Enabling back area shortcuts
wdanilo Sep 20, 2022
68c2056
Refactoring to make scrolling a little bit more correct. Scrolling st…
wdanilo Sep 21, 2022
e5b7b09
Added support for truncated text
wdanilo Sep 21, 2022
c6f27f8
Refactoring
wdanilo Sep 21, 2022
7487b3d
Making the ellipsis animation nicer
wdanilo Sep 21, 2022
a3a9a3e
Refactoring
wdanilo Sep 21, 2022
9ec9365
Enabling unicode inserts in text area
wdanilo Sep 21, 2022
585737c
Removing debug prints
wdanilo Sep 21, 2022
afcfb71
Refactoring, making Column the default parametrization of Location
wdanilo Sep 21, 2022
17d2a4e
Cleaning line code
wdanilo Sep 21, 2022
16cf736
Moving line unit to usize, adding LineDiff unit
wdanilo Sep 21, 2022
597b00d
Moving text area to new frp definition macro
wdanilo Sep 22, 2022
4feda84
Moving selection ID to separate type
wdanilo Sep 22, 2022
9430072
Changing the name Area to Text
wdanilo Sep 22, 2022
e7c2d72
Refactoring crate names
wdanilo Sep 22, 2022
7bb2287
Refactoring
wdanilo Sep 22, 2022
84e5b4b
Refactoring
wdanilo Sep 22, 2022
fcb5337
Fixing \r\n line handling
wdanilo Sep 22, 2022
3463f86
Refactoring frp
wdanilo Sep 22, 2022
fb0c055
Refactoring
wdanilo Sep 22, 2022
4eb042f
Refactoring
wdanilo Sep 22, 2022
5451eb5
Refactoring frp gen macro
wdanilo Sep 22, 2022
c687efb
Adding WeakFrp version to the frp endpoints generator
wdanilo Sep 22, 2022
3149056
Refactoring
wdanilo Sep 22, 2022
6349d5a
Refactoring selection component
wdanilo Sep 22, 2022
835f9d7
Fixing cursor blinking bug
wdanilo Sep 22, 2022
fb7b570
Refactoring
wdanilo Sep 22, 2022
24752d3
Fixing bugs
wdanilo Sep 22, 2022
419a9d3
Refactoring
wdanilo Sep 22, 2022
6a361fa
Refactoring
wdanilo Sep 22, 2022
9bf32f6
Refactoring
wdanilo Sep 22, 2022
9d9ea9f
Fixing blinking glyph bug
wdanilo Sep 22, 2022
1683ec8
Refactoring
wdanilo Sep 22, 2022
eb1e4ec
Refactoring
wdanilo Sep 22, 2022
d0bfcf2
Finished refactoring of text.rs
wdanilo Sep 22, 2022
734ccfc
Refactoring glyph.rs
wdanilo Sep 23, 2022
d150d38
Refactoring movement.rs
wdanilo Sep 23, 2022
a05f10b
Refactoring selection.rs
wdanilo Sep 23, 2022
f780943
Refactoring
wdanilo Sep 23, 2022
ebcb0c4
Unification of similar lines chunks
wdanilo Sep 23, 2022
129813a
Refactoring property diffs
wdanilo Sep 23, 2022
c311a91
Finishing refactoring of style.rs
wdanilo Sep 23, 2022
cc306cc
Renaming style.rs to refactoring.rs
wdanilo Sep 23, 2022
4b4b993
Refactoring
wdanilo Sep 23, 2022
c26903a
Refactoring
wdanilo Sep 24, 2022
2a58a62
Refactoring
wdanilo Sep 24, 2022
0a3a1ae
Linting
wdanilo Sep 24, 2022
a6563db
Linting
wdanilo Sep 24, 2022
2247a52
Linting the code
wdanilo Sep 24, 2022
5996811
Moving String to ImString in some FRP APIs
wdanilo Sep 24, 2022
feedd34
Moving Vec to Rc Vec in FRP endpoints
wdanilo Sep 24, 2022
d1681de
Refactoring
wdanilo Sep 24, 2022
2b6d93d
Uncommenting undo management
wdanilo Sep 24, 2022
514fd8b
Renaming, refactoring. Text -> Rope, etc.
wdanilo Sep 25, 2022
405b760
Refactoring
wdanilo Sep 25, 2022
dc732d3
Refactoring
wdanilo Sep 25, 2022
6b1bd28
Refactoring
wdanilo Sep 25, 2022
506d72b
Unification of BufferModel and BufferViewModel
wdanilo Sep 25, 2022
e83d8bd
Adding missing conversions
wdanilo Sep 26, 2022
dc28e0e
TryInContext -> TryInContextSnapped
wdanilo Sep 26, 2022
0dd89d4
Refactoring
wdanilo Sep 26, 2022
91b29f3
Refactoring
wdanilo Sep 26, 2022
f3b6aff
Refactoring
wdanilo Sep 26, 2022
391d1f0
Refactoring
wdanilo Sep 26, 2022
d9f1b91
Fixing redraw bug
wdanilo Sep 26, 2022
cc2a676
Linting
wdanilo Sep 26, 2022
eb6d03b
Refactoring
wdanilo Sep 26, 2022
cb792c5
Skipping line position animation on line creation.
wdanilo Sep 26, 2022
e298fe7
Applying review
wdanilo Sep 26, 2022
9a528a0
Fixing bug
wdanilo Sep 26, 2022
317ba79
Fixing set_selection_color
wdanilo Sep 26, 2022
b05b586
Fixing todos
wdanilo Sep 26, 2022
ca82932
Cleaning units
wdanilo Sep 26, 2022
7f6293e
Refactoring units
wdanilo Sep 26, 2022
5fc1b72
Refactoring
wdanilo Sep 26, 2022
00bde54
Partial fixes
farmaazon Sep 26, 2022
ffa665a
Refactoring
wdanilo Sep 26, 2022
9d4b552
Fixing byte sub opr
wdanilo Sep 26, 2022
e004be2
Merge branch 'wip/wdanilo/widgets-182746060' of github.com:enso-org/e…
wdanilo Sep 26, 2022
6a7fe77
Another part of fixes
farmaazon Sep 26, 2022
b332c96
Refactoring
wdanilo Sep 26, 2022
a269389
Fixing compilation of components
wdanilo Sep 27, 2022
1e1464f
Fixing native compilation
wdanilo Sep 27, 2022
ed29f90
Fixing wasing-animator example
wdanilo Sep 27, 2022
35a83fa
Fixes
farmaazon Sep 27, 2022
0e56622
Fixing wrong glyph placement after animations are skipped
wdanilo Sep 27, 2022
da7bb65
Merge branch 'wip/wdanilo/widgets-182746060' of github.com:enso-org/e…
wdanilo Sep 27, 2022
68d05ec
Fixing view compilation
wdanilo Sep 27, 2022
4a9b753
Making interface debug scene compile
wdanilo Sep 27, 2022
07b0893
Try to implement conversion
farmaazon Sep 27, 2022
91da5d9
Revert "Try to implement conversion"
wdanilo Sep 27, 2022
eb07676
Added conversion
farmaazon Sep 27, 2022
a802b09
Refactoring FromInContext from view to text. Preparation for proper d…
wdanilo Sep 27, 2022
5a41157
Merge branch 'wip/wdanilo/widgets-182746060' of github.com:enso-org/e…
wdanilo Sep 27, 2022
4f62c89
Revert "Added conversion"
wdanilo Sep 27, 2022
bec5b68
Revert "Revert "Added conversion""
farmaazon Sep 28, 2022
10a45e1
Another bunch of fixes
farmaazon Sep 27, 2022
d875d12
Properly displaying multiple unknown codepoints as one glyph, refacto…
wdanilo Sep 28, 2022
2ccdba3
Merge branch 'wip/wdanilo/widgets-182746060' of github.com:enso-org/e…
wdanilo Sep 28, 2022
1474f6c
Rope refactoring
wdanilo Sep 28, 2022
a451226
Refactoring
wdanilo Sep 28, 2022
17fdb8a
Refactoring
wdanilo Sep 28, 2022
8bb9f38
Refactoring
wdanilo Sep 28, 2022
be4dc21
Improving timings of performance stats
wdanilo Sep 28, 2022
71c6be0
Fixing bug of redrawing first empty line
wdanilo Sep 28, 2022
6e1f47c
Fixing last line animation
wdanilo Sep 28, 2022
c65b6f2
Refactoring
wdanilo Sep 28, 2022
b26fe31
Refactoring shaped lines from buffer to view
wdanilo Sep 28, 2022
a29f199
Refactoring
wdanilo Sep 28, 2022
18706a0
Refactoring
wdanilo Sep 28, 2022
406516a
Adding shortcuts requested in the review
wdanilo Sep 28, 2022
b6c6dd4
Refactoring
wdanilo Sep 28, 2022
4dd8848
Removing FRP network from private struct and thus fixing memory leak
wdanilo Sep 28, 2022
c48747b
Refactoring
wdanilo Sep 28, 2022
b9df803
Removing unused apis
wdanilo Sep 28, 2022
ce82840
Fixing bug of not updating width on selection-glyph removal
wdanilo Sep 28, 2022
c62e29c
Making suggestion database compatible with the new indexing system. F…
mwu-tow Sep 29, 2022
112de0e
Merge remote-tracking branch 'origin/wip/wdanilo/widgets-182746060' i…
mwu-tow Sep 29, 2022
c2f79a4
Fixing compilation of enso-gui
wdanilo Sep 29, 2022
846d2b5
Completing the controller adjustments.
mwu-tow Sep 30, 2022
9a7e5df
Making everything compile, tests to be fixed
wdanilo Sep 30, 2022
10cb119
Adding tests, refactoring text rope impl
wdanilo Sep 30, 2022
d894a00
Fixing errors
wdanilo Oct 1, 2022
9cd9a80
Refactoring code to the new API
wdanilo Oct 1, 2022
1ebad1e
Fixing native tests
wdanilo Oct 1, 2022
81f481c
Linting the code
wdanilo Oct 1, 2022
d6f5dbd
Merge branch 'develop' into wip/wdanilo/widgets-182746060
wdanilo Oct 1, 2022
8873613
Linting, formatting
wdanilo Oct 1, 2022
e2f692b
Linting
wdanilo Oct 2, 2022
5c809f1
Fixing CI build
wdanilo Oct 2, 2022
544b605
Fixed a failing test.
mwu-tow Oct 2, 2022
cb1036a
Fixing doc tests
wdanilo Oct 2, 2022
1e22661
Merge branch 'wip/wdanilo/widgets-182746060' of github.com:enso-org/e…
wdanilo Oct 2, 2022
513c0ae
Fix test
farmaazon Oct 3, 2022
587e1ef
Merge branch 'develop' into wip/wdanilo/widgets-182746060
wdanilo Oct 3, 2022
60fe5b6
remove unneeded dbg
mwu-tow Oct 3, 2022
41aa3c1
Formatting
wdanilo Oct 3, 2022
9ac375a
Applying review
wdanilo Oct 4, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
70 changes: 56 additions & 14 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions app/gui/analytics/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// === Standard Linter Configuration ===
#![deny(non_ascii_idents)]
#![warn(unsafe_code)]
#![allow(clippy::let_and_return)]
// === Non-Standard Linter Configuration ===
#![warn(missing_docs)]
#![warn(trivial_casts)]
Expand Down
1 change: 1 addition & 0 deletions app/gui/config/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// === Standard Linter Configuration ===
#![deny(non_ascii_idents)]
#![warn(unsafe_code)]
#![allow(clippy::let_and_return)]
// === Non-Standard Linter Configuration ===
#![warn(trivial_casts)]
#![warn(trivial_numeric_casts)]
Expand Down
1 change: 1 addition & 0 deletions app/gui/controller/double-representation/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
// === Standard Linter Configuration ===
#![deny(non_ascii_idents)]
#![warn(unsafe_code)]
#![allow(clippy::let_and_return)]
// === Non-Standard Linter Configuration ===
#![warn(missing_docs)]
#![warn(trivial_casts)]
Expand Down
4 changes: 2 additions & 2 deletions app/gui/controller/double-representation/src/module.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//! Code for module-level double representation processing.

use crate::prelude::*;
use enso_text::unit::*;
use enso_text::index::*;

use crate::alias_analysis;
use crate::definition;
Expand Down Expand Up @@ -828,7 +828,7 @@ pub fn lookup_method(
pub fn definition_span(
ast: &known::Module,
id: &definition::Id,
) -> FallibleResult<enso_text::Range<Bytes>> {
) -> FallibleResult<enso_text::Range<Byte>> {
let location = locate(ast, id)?;
ast.range_of_descendant_at(&location.crumbs)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,6 @@ mod tests {

impl Case {
fn run(&self, parser: &Parser) {
let logger = DefaultTraceLogger::new("Collapsing_Test");
let ast = parser.parse_module(self.initial_method_code, default()).unwrap();
let main = module::locate_child(&ast, &self.refactored_name).unwrap();
let graph = graph::GraphInfo::from_definition(main.item.clone());
Expand All @@ -417,14 +416,14 @@ mod tests {
let new_method = collapsed.new_method.ast(0, parser).unwrap();
let placement = module::Placement::Before(self.refactored_name.clone());
let new_main = &collapsed.updated_definition.ast;
info!(logger, "Generated method:\n{new_method}");
info!(logger, "Updated method:\n{new_method}");
info!("Generated method:\n{new_method}");
info!("Updated method:\n{new_method}");
let mut module = module::Info { ast: ast.clone_ref() };
let main_crumb = Crumb::from(main.crumb());
module.ast = module.ast.set(&main_crumb, new_main.ast().clone()).unwrap();
module.add_method(collapsed.new_method, placement, parser).unwrap();
ast::test_utils::assert_unique_ids(module.ast.as_ref());
info!(logger, "Updated method:\n{&module.ast}");
info!("Updated method:\n{}", &module.ast);
assert_eq!(new_method.repr(), self.expected_generated);
assert_eq!(new_main.repr(), self.expected_refactored);
};
Expand Down
Loading