Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Scala to 2.13.8 #3631

Merged
merged 15 commits into from
Aug 8, 2022
Merged

Update Scala to 2.13.8 #3631

merged 15 commits into from
Aug 8, 2022

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Aug 2, 2022

Pull Request Description

Update Scala compiler and libraries.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide dist and ./run ide watch.

@4e6 4e6 self-assigned this Aug 2, 2022
@4e6 4e6 requested review from jdunkerley and radeusgd as code owners August 2, 2022 14:47
@4e6 4e6 requested a review from hubertp August 2, 2022 14:49
radeusgd
radeusgd approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Just the Postgres downgrade startled me - is it on purpose?

Also I imagine we will need some legal review config updates to make this pass the CI.

build.sbt Outdated Show resolved Hide resolved
build.sbt Show resolved Hide resolved
@4e6 4e6 requested a review from JaroslavTulach as a code owner August 4, 2022 14:40
@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label Aug 4, 2022
@mergify mergify bot merged commit 5e114ac into develop Aug 8, 2022
@mergify mergify bot deleted the wip/db/scala-2.13.8 branch August 8, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@radeusgd radeusgd radeusgd approved these changes

@hubertp hubertp hubertp approved these changes

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley is a code owner

Assignees

@4e6 4e6

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@4e6 @hubertp @radeusgd @JaroslavTulach