Parser: implement import #3627
Merged
Parser: implement import #3627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
requested changes
Jul 29, 2022
|
We are implementing this sort of thing with "macros" (MultiSegmentApp) |
|
If I properly remember our yesterday conversation, then |
| " type Baz", | ||
| ]; | ||
| #[rustfmt::skip] | ||
| let expected = block
| @@ -106,7 +106,9 @@ impl FromMeta { | |||
| let mut fields = Vec::with_capacity(fields_.size_hint().0); | |||
| for field in fields_ { | |||
| let meta::Field { name, type_, hide, .. } = field; | |||
| let name = name.to_camel_case().expect("Unimplemented: Tuples."); | |||
| let mut name_ = meta::FieldName::from_snake_case("field"); | |||
There was a problem hiding this comment.
This change renamed even the public getters. Now I see Line.getFieldExpression() methods & co. Workarounded by aa2b63a#r940901973
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 3, 2022
…tions and signatures; fix field names (#3653) Implements: - UUIDs: https://www.pivotaltracker.com/story/show/182931137 - Comments: https://www.pivotaltracker.com/story/show/182981779 - Type annotations and signatures: https://www.pivotaltracker.com/story/show/182497454 - Fix getter names (#3627 (comment)). # Important Notes - I can't fully test UUIDs; I have tested that the data obtained in Rust matches my understanding of how the format is supposed to work. What remains to be tested is that the data in Java matches the way the old parser handles the format. So @JaroslavTulach, let me know if you see any cases where I'm not returning the same values. - This implementation of type annotations and signatures accepts any expression in type context. It would probably be nice to narrow this down at some point, but for now I have no design info on what specifically should be allowed in type expressions; this implementation should be at least an incremental improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Based on usage; I believe this handles every case in current
.ensofiles.Important Notes
importis a built-in macro, so an import statement parses as aMultiSegmentApp.importsyntax will have a segment whose leading keyword isimport; howeverimportmacros can be identified more efficiently by looking at only the first keyword. AMultiSegmentAppis an import if and only if its first keyword is in the set { "polyglot", "from", "import" }.Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide distand./run ide watch.[ci no changelog needed]